Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(file sink): Adhere to instrumentation spec #14302

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

neuronull
Copy link
Contributor

Closes: #14226

Epic: #13995

@neuronull neuronull added domain: observability Anything related to monitoring/observing Vector sink: file Anything `file` sink related labels Sep 6, 2022
@neuronull neuronull self-assigned this Sep 6, 2022
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 1440879
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/6317c3ba7d7f4a0008bbf44e
😎 Deploy Preview https://deploy-preview-14302--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Soak Test Results

Baseline: 60d439d
Comparison: 1440879
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
splunk_hec_route_s3 329.36KiB 1.71 100.00% 18.78MiB 2.3MiB 47.93KiB 0 0.122547 19.1MiB 2.15MiB 45.05KiB 0 0.112758 False False
socket_to_socket_blackhole 284.35KiB 1.21 100.00% 22.91MiB 139.65KiB 2.85KiB 0 0.00595229 23.18MiB 106.09KiB 2.17KiB 0 0.00446749 False False
http_text_to_http_json 449.84KiB 1.1 100.00% 39.9MiB 684.83KiB 13.98KiB 0 0.0167584 40.34MiB 691.66KiB 14.12KiB 0 0.0167412 False False
syslog_splunk_hec_logs 128.22KiB 0.76 100.00% 16.53MiB 756.23KiB 15.39KiB 0 0.0446715 16.65MiB 591.7KiB 12.07KiB 0 0.0346898 False False
datadog_agent_remap_blackhole_acks 467.97KiB 0.76 99.81% 59.97MiB 5.6MiB 116.69KiB 0 0.0934194 60.43MiB 4.53MiB 94.84KiB 0 0.0749474 False False
syslog_humio_logs 68.06KiB 0.4 100.00% 16.64MiB 149.08KiB 3.04KiB 0 0.0087474 16.71MiB 136.45KiB 2.79KiB 0 0.00797455 False False
syslog_log2metric_splunk_hec_metrics 14.68KiB 0.08 38.16% 17.23MiB 964.61KiB 19.67KiB 0 0.0546666 17.24MiB 1.05MiB 21.95KiB 0 0.0610674 False False
splunk_hec_to_splunk_hec_logs_noack 11.71KiB 0.05 70.86% 23.83MiB 430.62KiB 8.79KiB 0 0.0176456 23.84MiB 331.93KiB 6.78KiB 0 0.013595 False False
syslog_loki 7.11KiB 0.05 25.82% 14.28MiB 567.65KiB 11.62KiB 0 0.0388132 14.29MiB 894.6KiB 18.19KiB 0 0.0611391 False False
enterprise_http_to_http 571.7B 0 6.13% 23.85MiB 250.8KiB 5.12KiB 0 0.010269 23.85MiB 251.81KiB 5.15KiB 0 0.0103098 False False
splunk_hec_to_splunk_hec_logs_acks -1.66KiB -0.01 5.34% 23.75MiB 858.6KiB 17.46KiB 0 0.0352972 23.75MiB 865.01KiB 17.59KiB 0 0.0355632 False False
file_to_blackhole -26.46KiB -0.03 21.93% 95.34MiB 3.25MiB 67.38KiB 0 0.0340916 95.32MiB 3.22MiB 67.04KiB 0 0.0338107 False False
splunk_hec_indexer_ack_blackhole -8.28KiB -0.03 24.64% 23.75MiB 891.33KiB 18.13KiB 0 0.0366379 23.75MiB 942.73KiB 19.18KiB 0 0.0387636 False False
http_pipelines_blackhole_acks -936.23B -0.07 22.93% 1.19MiB 128.22KiB 2.61KiB 0 0.105117 1.19MiB 85.3KiB 1.74KiB 0 0.0699808 False False
http_to_http_json -41.99KiB -0.17 99.86% 23.85MiB 331.62KiB 6.77KiB 0 0.0135772 23.81MiB 549.65KiB 11.22KiB 0 0.0225428 False False
fluent_elasticsearch -262.64KiB -0.32 100.00% 79.47MiB 53.27KiB 1.08KiB 0 0.000654395 79.22MiB 2.63MiB 54.06KiB 0 0.0331788 False False
http_to_http_noack -105.29KiB -0.43 100.00% 23.84MiB 407.5KiB 8.32KiB 0 0.0166903 23.74MiB 1.15MiB 23.9KiB 0 0.0482903 False False
syslog_regex_logs2metric_ddmetrics -61.41KiB -0.48 99.73% 12.46MiB 701.39KiB 14.29KiB 0 0.0549659 12.4MiB 716.94KiB 14.61KiB 0 0.0564562 False False
http_to_http_acks -86.22KiB -0.48 28.86% 17.51MiB 7.92MiB 165.58KiB 0 0.452179 17.43MiB 7.85MiB 164.0KiB 0 0.450487 True True
syslog_log2metric_humio_metrics -99.63KiB -0.78 100.00% 12.48MiB 435.94KiB 8.9KiB 0 0.034105 12.38MiB 625.48KiB 12.73KiB 0 0.0493176 False False
datadog_agent_remap_datadog_logs -668.15KiB -1.07 100.00% 60.74MiB 2.08MiB 43.64KiB 0 0.0342671 60.09MiB 4.53MiB 94.28KiB 0 0.0753428 False False
datadog_agent_remap_datadog_logs_acks -691.41KiB -1.14 100.00% 59.17MiB 4.64MiB 96.93KiB 0 0.078381 58.5MiB 5.37MiB 111.72KiB 0 0.091724 False False
http_pipelines_no_grok_blackhole -179.07KiB -1.63 100.00% 10.72MiB 478.17KiB 9.76KiB 0 0.0435597 10.54MiB 1.17MiB 24.27KiB 0 0.110578 False False
datadog_agent_remap_blackhole -2.12MiB -3.47 100.00% 61.14MiB 3.81MiB 79.54KiB 0 0.062386 59.01MiB 4.11MiB 85.81KiB 0 0.069611 False False
http_pipelines_blackhole -92.96KiB -5.49 100.00% 1.65MiB 95.83KiB 1.96KiB 0 0.0565923 1.56MiB 150.39KiB 3.07KiB 0 0.0939682 False False

@neuronull neuronull merged commit 0ae5e20 into master Sep 7, 2022
@neuronull neuronull deleted the neuronull/audit1_sink_file branch September 7, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks sink: file Anything `file` sink related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify file sink
2 participants