Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(http sink): Adhere to instrumentation spec #14361

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

neuronull
Copy link
Contributor

Closes: #14301

Epic: #13995

Error and EventsDropped emission seems to be handled by common code for this sink.

@neuronull neuronull added sink: http Anything `http` sink related domain: observability Anything related to monitoring/observing Vector labels Sep 9, 2022
@neuronull neuronull self-assigned this Sep 9, 2022
@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit afceb08
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/631b990f1a958a0009b87364
😎 Deploy Preview https://deploy-preview-14361--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Soak Test Results

Baseline: f705842
Comparison: afceb08
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

Changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

experiment Δ mean Δ mean % confidence
socket_to_socket_blackhole 1.93MiB 8.91 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
socket_to_socket_blackhole 1.93MiB 8.91 100.00% 21.64MiB 3.29MiB 68.73KiB 0 0.151885 23.57MiB 154.75KiB 3.16KiB 0 0.00641025 False False
datadog_agent_remap_blackhole 1.53MiB 2.65 100.00% 57.65MiB 5.31MiB 110.66KiB 0 0.092057 59.18MiB 4.19MiB 87.39KiB 0 0.0707621 False False
syslog_regex_logs2metric_ddmetrics 326.7KiB 2.63 100.00% 12.12MiB 679.51KiB 13.86KiB 0 0.0547378 12.44MiB 559.22KiB 11.39KiB 0 0.043892 False False
datadog_agent_remap_datadog_logs 1.41MiB 2.33 100.00% 60.37MiB 3.06MiB 64.22KiB 0 0.0507218 61.77MiB 4.22MiB 87.79KiB 0 0.0682432 False False
syslog_log2metric_splunk_hec_metrics 250.8KiB 1.43 100.00% 17.18MiB 1.06MiB 22.13KiB 0 0.0617164 17.43MiB 1.08MiB 22.54KiB 0 0.0621005 False False
datadog_agent_remap_datadog_logs_acks 788.74KiB 1.27 100.00% 60.71MiB 3.95MiB 82.5KiB 0 0.0649742 61.48MiB 4.41MiB 91.72KiB 0 0.0716553 False False
http_pipelines_blackhole_acks 7.34KiB 0.61 98.56% 1.18MiB 119.33KiB 2.43KiB 0 0.098644 1.19MiB 86.1KiB 1.76KiB 0 0.0707442 False False
syslog_log2metric_humio_metrics 72.76KiB 0.57 100.00% 12.45MiB 552.36KiB 11.27KiB 0 0.0433109 12.52MiB 616.62KiB 12.56KiB 0 0.0480759 False False
syslog_humio_logs 75.05KiB 0.46 100.00% 15.78MiB 280.7KiB 5.73KiB 0 0.0173694 15.85MiB 345.32KiB 7.07KiB 0 0.0212697 False False
datadog_agent_remap_blackhole_acks 227.22KiB 0.36 96.95% 61.85MiB 4.25MiB 88.44KiB 0 0.0686543 62.07MiB 2.7MiB 56.54KiB 0 0.0435295 False False
http_pipelines_no_grok_blackhole 36.7KiB 0.34 89.32% 10.59MiB 525.62KiB 10.73KiB 0 0.0484562 10.63MiB 985.53KiB 20.06KiB 0 0.0905479 False False
http_text_to_http_json 70.73KiB 0.18 99.59% 37.95MiB 872.23KiB 17.8KiB 0 0.0224386 38.02MiB 834.29KiB 17.03KiB 0 0.0214235 False False
splunk_hec_to_splunk_hec_logs_noack 23.6KiB 0.1 94.13% 23.82MiB 509.16KiB 10.39KiB 0 0.0208716 23.84MiB 338.6KiB 6.92KiB 0 0.0138664 False False
splunk_hec_indexer_ack_blackhole 2.91KiB 0.01 8.93% 23.75MiB 894.66KiB 18.2KiB 0 0.0367812 23.75MiB 905.15KiB 18.42KiB 0 0.037208 False False
enterprise_http_to_http 715.37B 0 7.61% 23.85MiB 253.59KiB 5.18KiB 0 0.0103835 23.85MiB 252.77KiB 5.17KiB 0 0.0103496 False False
file_to_blackhole -39.25KiB -0.04 28.34% 95.33MiB 3.57MiB 74.03KiB 0 0.0374721 95.3MiB 3.79MiB 78.8KiB 0 0.0397185 False False
http_pipelines_blackhole -1.55KiB -0.09 43.75% 1.69MiB 58.82KiB 1.2KiB 0 0.0340074 1.69MiB 117.0KiB 2.38KiB 0 0.0677022 False False
splunk_hec_to_splunk_hec_logs_acks -27.92KiB -0.11 74.79% 23.77MiB 790.99KiB 16.1KiB 0 0.0324928 23.74MiB 900.43KiB 18.31KiB 0 0.0370311 False False
http_to_http_json -39.99KiB -0.16 99.79% 23.85MiB 334.91KiB 6.84KiB 0 0.0137128 23.81MiB 542.43KiB 11.07KiB 0 0.0222456 False False
http_to_http_noack -76.5KiB -0.31 99.94% 23.84MiB 408.95KiB 8.37KiB 0 0.0167504 23.76MiB 1016.37KiB 20.7KiB 0 0.041761 False False
syslog_splunk_hec_logs -64.69KiB -0.39 99.94% 16.38MiB 705.39KiB 14.37KiB 0 0.0420574 16.31MiB 600.29KiB 12.25KiB 0 0.0359294 False False
fluent_elasticsearch -418.89KiB -0.51 100.00% 79.47MiB 53.72KiB 1.08KiB 0 0.000659928 79.06MiB 4.54MiB 93.17KiB 0 0.0573537 False False
syslog_loki -100.08KiB -0.69 100.00% 14.14MiB 512.88KiB 10.51KiB 0 0.0354195 14.04MiB 849.49KiB 17.27KiB 0 0.0590746 False False
http_to_http_acks -198.4KiB -1.12 59.53% 17.35MiB 8.19MiB 171.1KiB 0 0.471644 17.16MiB 7.93MiB 165.53KiB 0 0.462027 True True
splunk_hec_route_s3 -225.91KiB -1.19 99.89% 18.53MiB 2.34MiB 48.77KiB 0 0.126234 18.31MiB 2.35MiB 49.21KiB 0 0.128494 False False

@neuronull neuronull merged commit 0056ffe into master Sep 12, 2022
@neuronull neuronull deleted the neuronull/audit1_sink_http branch September 12, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks sink: http Anything `http` sink related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify http sink
2 participants