Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(vector sink): Comply to *EventsDropped instrumentation spec in vector sink #14516

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

pablosichert
Copy link
Contributor

Closes #14215.

Part of #13995.

Emitting an error when the sink fails is handled in the service driver:

emit(service::PollReadyError{ error });

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 09798c5
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63455c3a1a3f520008e3d79c

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 22, 2022
@github-actions
Copy link

Soak Test Results

Baseline: d8ca608
Comparison: b4c0ac9
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
socket_to_socket_blackhole 1.28MiB 5.74 100.00% 22.36MiB 596.09KiB 12.17KiB 0 0.0260342 23.64MiB 649.15KiB 13.25KiB 0 0.0268135 False False
splunk_hec_route_s3 269.8KiB 1.43 100.00% 18.39MiB 2.31MiB 48.2KiB 0 0.125811 18.66MiB 2.18MiB 45.67KiB 0 0.117041 False False
datadog_agent_remap_blackhole_acks 836.66KiB 1.34 100.00% 61.0MiB 4.38MiB 91.15KiB 0 0.0717581 61.82MiB 2.62MiB 54.79KiB 0 0.0423537 False False
datadog_agent_remap_blackhole 748.74KiB 1.26 100.00% 58.14MiB 5.27MiB 110.01KiB 0 0.0906971 58.87MiB 4.52MiB 94.3KiB 0 0.0767311 False False
http_pipelines_blackhole_acks 15.57KiB 1.24 100.00% 1.22MiB 116.77KiB 2.38KiB 0 0.0932793 1.24MiB 77.16KiB 1.57KiB 0 0.0608825 False False
syslog_loki 166.85KiB 1.13 100.00% 14.36MiB 402.35KiB 8.25KiB 0 0.0273539 14.52MiB 836.44KiB 17.0KiB 0 0.0562281 False False
http_text_to_http_json 433.69KiB 1.09 100.00% 38.73MiB 1.24MiB 25.98KiB 0 0.032085 39.15MiB 1.14MiB 23.85KiB 0 0.0291282 False False
syslog_log2metric_humio_metrics 114.94KiB 0.91 100.00% 12.35MiB 234.9KiB 4.79KiB 0 0.0185745 12.46MiB 523.03KiB 10.65KiB 0 0.0409854 False False
http_to_http_acks 125.43KiB 0.71 40.30% 17.19MiB 8.19MiB 171.19KiB 0 0.476363 17.31MiB 7.87MiB 164.21KiB 0 0.454647 True True
syslog_regex_logs2metric_ddmetrics 67.14KiB 0.53 99.99% 12.36MiB 600.16KiB 12.22KiB 0 0.0474 12.43MiB 572.9KiB 11.67KiB 0 0.045009 False False
datadog_agent_remap_datadog_logs_acks 130.05KiB 0.21 77.41% 61.12MiB 2.65MiB 55.37KiB 0 0.0432801 61.24MiB 4.42MiB 91.99KiB 0 0.0721429 False False
splunk_hec_to_splunk_hec_logs_noack 30.09KiB 0.12 97.83% 23.81MiB 546.39KiB 11.15KiB 0 0.0224053 23.84MiB 336.6KiB 6.87KiB 0 0.0137854 False False
syslog_splunk_hec_logs 5.41KiB 0.03 18.24% 16.09MiB 855.81KiB 17.41KiB 0 0.0519358 16.09MiB 772.45KiB 15.74KiB 0 0.0468611 False False
splunk_hec_indexer_ack_blackhole 5.46KiB 0.02 15.53% 23.73MiB 976.99KiB 19.86KiB 0 0.0401895 23.74MiB 961.04KiB 19.54KiB 0 0.0395247 False False
syslog_humio_logs 2.34KiB 0.01 15.72% 16.06MiB 411.68KiB 8.41KiB 0 0.0250334 16.06MiB 402.53KiB 8.25KiB 0 0.0244738 False False
enterprise_http_to_http -2.53KiB -0.01 27.19% 23.85MiB 249.21KiB 5.09KiB 0 0.0102034 23.84MiB 253.51KiB 5.19KiB 0 0.0103806 False False
splunk_hec_to_splunk_hec_logs_acks -10.88KiB -0.04 34.34% 23.76MiB 828.92KiB 16.87KiB 0 0.0340648 23.75MiB 870.93KiB 17.72KiB 0 0.0358071 False False
file_to_blackhole -71.01KiB -0.07 57.46% 95.34MiB 2.88MiB 59.61KiB 0 0.0301565 95.27MiB 3.18MiB 66.2KiB 0 0.0334139 False False
http_to_http_json -46.32KiB -0.19 99.94% 23.85MiB 327.16KiB 6.68KiB 0 0.0133945 23.8MiB 569.24KiB 11.61KiB 0 0.0233501 False False
datadog_agent_remap_datadog_logs -137.4KiB -0.22 86.64% 62.16MiB 816.41KiB 16.7KiB 0 0.0128237 62.02MiB 4.32MiB 90.04KiB 0 0.0697105 False False
fluent_elasticsearch -201.22KiB -0.25 100.00% 79.47MiB 52.46KiB 1.06KiB 0 0.000644468 79.28MiB 1.78MiB 36.64KiB 0 0.0224572 False False
http_to_http_noack -122.78KiB -0.5 100.00% 23.85MiB 247.74KiB 5.07KiB 0 0.0101437 23.73MiB 1.19MiB 24.84KiB 0 0.0502246 False False
syslog_log2metric_splunk_hec_metrics -94.2KiB -0.53 99.99% 17.46MiB 717.76KiB 14.63KiB 0 0.0401387 17.37MiB 899.06KiB 18.29KiB 0 0.0505434 False False
http_pipelines_blackhole -9.88KiB -0.6 99.98% 1.6MiB 34.75KiB 727.42B 0 0.0212423 1.59MiB 126.53KiB 2.58KiB 0 0.077814 False False
http_pipelines_no_grok_blackhole -141.82KiB -1.29 100.00% 10.74MiB 124.8KiB 2.55KiB 0 0.0113465 10.6MiB 1.03MiB 21.44KiB 0 0.0971224 False False

@jszwedko jszwedko requested a review from a team October 7, 2022 13:34
src/sinks/aws_cloudwatch_metrics/mod.rs Outdated Show resolved Hide resolved
src/sinks/aws_cloudwatch_metrics/mod.rs Outdated Show resolved Hide resolved
src/sinks/redis.rs Show resolved Hide resolved
Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to Kyle's comments

@pablosichert pablosichert force-pushed the pablosichert/vector-sink-verify-compliance branch from b4c0ac9 to 09798c5 Compare October 11, 2022 12:06
@pablosichert pablosichert enabled auto-merge (squash) October 11, 2022 12:08
@pablosichert pablosichert merged commit 93b223e into master Oct 11, 2022
@pablosichert pablosichert deleted the pablosichert/vector-sink-verify-compliance branch October 11, 2022 13:33
@jszwedko jszwedko added this to the Vector v0.25.0 milestone Oct 27, 2022
jszwedko pushed a commit that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify vector sink
4 participants