Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Move most CI checks to merge queue #17340
chore(ci): Move most CI checks to merge queue #17340
Changes from 220 commits
1f054de
9caf8cf
4c4ead9
a3ef6af
122c4c5
ccd98db
1e1951e
7a762af
7b55c19
149b7f2
ba9df94
4b30c5d
fd7dd67
63845fc
11bff58
bbd961f
e2a3c5c
f0e3c29
a462bd8
70aee4b
f53f09c
bef839d
1318ccc
5d07909
c440e41
7cec18c
36281b8
91f5521
bf3e656
56a2386
f64e0f4
fc13e20
7e093e9
916f517
7df850f
c73dcdd
413b9a5
6dc1d97
4bb5d91
abe7127
2306380
da0ebf7
51ae61e
a000905
fe859c3
b24fa49
20bb7a1
e90ff05
b996ff5
72acc1e
411ade8
102adff
a3a7226
e4dabc4
28874d8
f088fa1
8668a62
dcd2888
c62c9c4
d06d307
b80717f
fc93a70
af923fd
269c6d8
cda0ac0
b3c24da
8694337
bcf3b6a
5fbe4c4
ff39c08
621ef2c
b2c4865
134f36f
04c5920
986aa2f
8acc7e6
e7f6ba6
c02106d
1054934
e4df03b
aff1ccd
03e4a65
d16e2bf
5ea6db9
9e70ce4
debeebe
81dbb58
b46f677
2fc8b49
f7e4206
f901fc2
88a61ab
38c8e1e
320c8e9
b236e98
b747bca
e29ea2f
9642aba
cefa826
598f407
07e6388
09e62be
871b693
fe70713
6e98ed4
66118df
24cdd38
fb4d7d9
73576dc
7067666
67198ae
a71b845
bbae3bf
70c5585
725b64b
7c5c2e3
881574c
a6bc74c
18cc6cb
b823417
cde2d27
3962e4e
3c7fb23
fa7d5a1
0b78789
6dc6cd2
37140ac
cd73258
dc8ff61
85aa21c
8589665
be1da81
c1a05e9
0aed9fc
54077fb
83764f8
4df68e8
45e5067
af2b195
484168f
42d15a0
82ab049
8b909f6
c4325b7
1de77c6
8a229ac
d442c92
3bd7c24
a3371bb
f8c13b8
fff5992
dc699b4
7d10985
02d28a8
f4c2f38
d940bab
4de3874
7498408
bdbb9cd
d96ccee
375f6a3
2f32589
4899501
e782d09
8c2d086
2aad1d7
68923e1
035765e
4712e00
4c3eae9
930e409
69aa124
7d00508
f40154c
d5b202f
d780da1
9c1dc09
2207acc
29ac7dc
0c5ed45
dc929e2
1138a08
47246f8
75cdf1f
44ead21
0d5b580
5f0b8ff
b940457
d43aeb5
369cf4f
ddeecbd
b1daf60
d3ed90f
09abb8c
20aed4f
d5a1cfb
f0511c8
219d51d
a5c87ed
139ec58
dcd8fff
2397499
c1dbced
6a68cdf
52416e3
a59eaaa
bbfd789
975434d
2524931
8f29583
47dea5f
0ad782a
fa3906c
46c7ba1
36e6135
b14f91c
6f5531a
32ce960
96900d6
3307a62
91c974b
305b4a7
1d6dcaf
4737b07
7812007
21227f0
37ec4c0
a677e9f
305f642
e03aecb
1bd175d
6f8a5c5
789e3e5
311de48
2bd2f25
5bfafa4
d356d76
dd23290
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a follow-up, but I'd love to see these closer to the tests themselves in https://github.com/vectordotdev/vector/blob/master/scripts/integration/amqp/test.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.. I did see they have an option to define them in a separate file. It shouldn't be hard to add that.
Though, from what I'm seeing it is a single file to read from 🤔 (as opposed to a file-per key)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I suppose could split that out into different jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also add a subcommand to
vdev integration
that spits out the file paths by parsing thetest.yaml
files and call that in CI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I do like that better... Ok, I think that is a good candidate for a follow-up task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the integration tests, it struck me that we might want to check for changes in common places like 'lib/' or something like that, and run all of them.
Wanted to get team's thoughts on that as I'm sure there would be some cases where that wouldn't be necessary, but figured "core" code utilized everywhere might benefit from that.