Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): restrict k8s workflow runs #17416

Merged
merged 4 commits into from
May 19, 2023

Conversation

neuronull
Copy link
Contributor

@neuronull neuronull commented May 16, 2023

Restricts the running of k8s tests.
We now run all versions once nightly on weeknights.
Otherwise, run only the latest version.

To track the workflow, we will setup the slack GH App to subscribe to the workflow.

@neuronull neuronull changed the title Neuronull/ci save on k8s chore(ci): restrict k8s workflow runs May 16, 2023
@neuronull neuronull self-assigned this May 16, 2023
@neuronull neuronull added the domain: ci Anything related to Vector's CI environment label May 16, 2023
@neuronull neuronull marked this pull request as ready for review May 16, 2023 20:58
@neuronull neuronull requested a review from jszwedko May 16, 2023 20:58
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about how we'll keep abreast of failures, otherwise 👍

Comment on lines +24 to +26
schedule:
# At midnight UTC Tue-Sat
- cron: '0 0 * * 2-6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we be notified if the scheduled build fails? I just want to make sure it doesn't slip through the cracks. Maybe we could take this opportunity to setup a Slack notification?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Datadog Monitor 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, yeah that's kinda important lol.
I'll take a look at adding a Datadog Monitor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some research and discussion, we will try the GHA workflow notifications in slack first and pivot if needed.
There aren't any edits needed to the workflow file itself for that.

@github-actions
Copy link

Regression Detector Results

Run ID: 4b17c11a-6c2b-4901-b9a7-347cee86b2a8
Baseline: 305b4a7
Comparison: 7812007
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
syslog_log2metric_humio_metrics ingress throughput +4.07 [+3.97, +4.16] 100.00%
splunk_hec_route_s3 ingress throughput +1.94 [+1.80, +2.08] 100.00%
syslog_splunk_hec_logs ingress throughput +1.60 [+1.53, +1.67] 100.00%
datadog_agent_remap_blackhole_acks ingress throughput +1.29 [+1.21, +1.38] 100.00%
http_to_http_acks ingress throughput +0.76 [-0.48, +1.99] 56.81%
datadog_agent_remap_datadog_logs ingress throughput +0.46 [+0.36, +0.57] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput +0.45 [+0.21, +0.68] 98.56%
file_to_blackhole ingress throughput +0.06 [+0.01, +0.11] 84.64%
enterprise_http_to_http ingress throughput +0.03 [-0.00, +0.06] 78.58%
fluent_elasticsearch ingress throughput +0.00 [-0.00, +0.00] 7.63%
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.07, +0.06] 7.16%
syslog_humio_logs ingress throughput -0.00 [-0.08, +0.07] 6.04%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.05, +0.04] 13.20%
http_to_http_noack ingress throughput -0.03 [-0.08, +0.03] 43.75%
splunk_hec_indexer_ack_blackhole ingress throughput -0.03 [-0.07, +0.01] 59.47%
otlp_http_to_blackhole ingress throughput -0.08 [-0.25, +0.10] 41.53%
http_text_to_http_json ingress throughput -0.56 [-0.62, -0.51] 100.00%
http_to_http_json ingress throughput -0.59 [-0.63, -0.54] 100.00%
otlp_grpc_to_blackhole ingress throughput -0.70 [-0.81, -0.59] 100.00%
syslog_log2metric_splunk_hec_metrics ingress throughput -0.75 [-0.84, -0.67] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput -0.82 [-0.91, -0.72] 100.00%
socket_to_socket_blackhole ingress throughput -0.97 [-1.03, -0.92] 100.00%
datadog_agent_remap_blackhole ingress throughput -1.56 [-1.63, -1.49] 100.00%
syslog_loki ingress throughput -3.64 [-3.71, -3.56] 100.00%

@github-actions github-actions bot removed the domain: ci Anything related to Vector's CI environment label May 17, 2023
@github-actions
Copy link

Regression Detector Results

Run ID: 41f024e3-9e8e-47e1-ad25-282098181021
Baseline: 311de48
Comparison: 5bfafa4
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
syslog_loki ingress throughput +2.49 [+2.39, +2.58] 100.00%
syslog_log2metric_humio_metrics ingress throughput +1.46 [+1.38, +1.53] 100.00%
otlp_grpc_to_blackhole ingress throughput +1.32 [+1.21, +1.43] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput +1.31 [+1.23, +1.40] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput +1.04 [+0.76, +1.33] 100.00%
syslog_humio_logs ingress throughput +0.91 [+0.85, +0.96] 100.00%
splunk_hec_route_s3 ingress throughput +0.57 [+0.45, +0.70] 100.00%
syslog_splunk_hec_logs ingress throughput +0.30 [+0.21, +0.40] 100.00%
datadog_agent_remap_datadog_logs ingress throughput +0.30 [+0.21, +0.39] 100.00%
socket_to_socket_blackhole ingress throughput +0.10 [+0.03, +0.17] 94.59%
http_to_http_json ingress throughput +0.08 [+0.04, +0.13] 97.40%
enterprise_http_to_http ingress throughput +0.06 [+0.02, +0.10] 96.16%
file_to_blackhole ingress throughput +0.06 [+0.01, +0.11] 87.04%
splunk_hec_indexer_ack_blackhole ingress throughput +0.01 [-0.03, +0.05] 20.16%
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.01 [-0.04, +0.05] 13.32%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.06, +0.06] 1.05%
fluent_elasticsearch ingress throughput -0.00 [-0.00, +0.00] 31.38%
syslog_log2metric_splunk_hec_metrics ingress throughput -0.01 [-0.12, +0.10] 8.61%
http_to_http_noack ingress throughput -0.01 [-0.07, +0.05] 21.35%
datadog_agent_remap_blackhole ingress throughput -0.29 [-0.38, -0.20] 100.00%
http_to_http_acks ingress throughput -0.69 [-1.91, +0.53] 53.09%
http_text_to_http_json ingress throughput -0.71 [-0.76, -0.65] 100.00%
otlp_http_to_blackhole ingress throughput -0.90 [-1.07, -0.74] 100.00%
datadog_agent_remap_blackhole_acks ingress throughput -1.45 [-1.55, -1.36] 100.00%

@neuronull neuronull merged commit d356d76 into neuronull/ci_add_merge_queue May 19, 2023
@neuronull neuronull deleted the neuronull/ci_save_on_k8s branch May 19, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants