-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(observability): issues with event_cache PR #17768
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -252,6 +252,62 @@ configuration: { | |
} | ||
} | ||
|
||
telemetry: { | ||
common: false | ||
description: """ | ||
Configures options for how Vector emits telemetry. | ||
""" | ||
required: false | ||
type: object: { | ||
examples: [] | ||
options: { | ||
tags: { | ||
required: false | ||
description: """ | ||
Controls which tags should be included with the `vector_component_sent_events_total` and | ||
`vector_component_sent_event_bytes_total` metrics. | ||
""" | ||
type: object: { | ||
examples: [] | ||
options: { | ||
emit_source: { | ||
common: true | ||
description: """ | ||
Add a `source` tag with the source component the event was received from. | ||
|
||
If there is no source component, for example if the event was generated by | ||
the `lua` transform a `-` is emitted for this tag. | ||
""" | ||
required: false | ||
type: bool: { | ||
default: false | ||
} | ||
} | ||
emit_service: { | ||
common: false | ||
description: """ | ||
Adds a `service` tag with the service component the event was received from. | ||
|
||
For logs this is the field that has been determined to mean `service`. Each source may | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The docs for this section should be updated with a link to the section about meanings when that section exists. |
||
define different fields for this. For example, with `syslog` events the `appname` field | ||
is used. | ||
|
||
Metric events will use the tag named `service`. | ||
|
||
If no service is available a `-` is emitted for this tag. | ||
""" | ||
required: false | ||
type: bool: { | ||
default: false | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} | ||
|
||
log_schema: { | ||
common: false | ||
description: """ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it that this is not generated from the
configurable
trait? Maybe that doesn't work for global options?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm pretty sure it only works for components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 but global options are marked with configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc/ @tobz to confirm. Maybe it just isn't handled by the Ruby script that turns the JSON schema into cue docs yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no
reference/base
to include them in the cue file from..