Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codecs) csv encoding quoting bug #18320

Merged
merged 16 commits into from
Aug 29, 2023
Merged

fix(codecs) csv encoding quoting bug #18320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
125d249
added additional csv configuration options
scMarkus Aug 18, 2023
1294d24
implemented suggestions of pront
scMarkus Aug 18, 2023
e19d85a
added configurable QuotingStyle and made problematic quoted tests pas…
scMarkus Aug 18, 2023
b08f938
switched to defaults by serde
scMarkus Aug 18, 2023
cc2d0d2
refactor csv codec to use low level csv-core to fix missing closing q…
scMarkus Aug 21, 2023
0bf59c6
fixed typo
scMarkus Aug 21, 2023
2fdbc17
use field iterator to count written filds instead of manual counter
scMarkus Aug 21, 2023
5938e35
moved internal_buffer into CsvSerializer to not recreated with every …
scMarkus Aug 21, 2023
25c027d
improoved comments
scMarkus Aug 21, 2023
fda0cbf
implemented suggestions
scMarkus Aug 22, 2023
f28ba03
cleanup
scMarkus Aug 22, 2023
8e6d84f
refactored test
scMarkus Aug 23, 2023
71d2bf9
low level csv writer api refactor
scMarkus Aug 23, 2023
f761a17
Revert "low level csv writer api refactor"
scMarkus Aug 23, 2023
6224fe2
some more cleanup
scMarkus Aug 23, 2023
75a55fd
generate-component-docs
scMarkus Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codecs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ publish = false
apache-avro = { version = "0.15.0", default-features = false }
bytes = { version = "1", default-features = false }
chrono = { version = "0.4", default-features = false }
csv = { version = "1.2", default-features = false }
csv-core = { version = "0.1.10", default-features = false }
derivative = { version = "2", default-features = false }
dyn-clone = { version = "1", default-features = false }
lookup = { package = "vector-lookup", path = "../vector-lookup", default-features = false }
Expand Down
Loading