Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(releasing): Prepare v0.33.1 release #18974

Merged
merged 14 commits into from
Oct 30, 2023
Merged

chore(releasing): Prepare v0.33.1 release #18974

merged 14 commits into from
Oct 30, 2023

Conversation

jszwedko
Copy link
Member

dependabot bot and others added 7 commits October 27, 2023 16:00
Bumps [tokio-tungstenite](https://github.com/snapview/tokio-tungstenite) from 0.20.0 to 0.20.1.
- [Changelog](https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md)
- [Commits](snapview/tokio-tungstenite@v0.20.0...v0.20.1)

---
updated-dependencies:
- dependency-name: tokio-tungstenite
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): Bump webpki from 0.22.1 to 0.22.2

Bumps [webpki](https://github.com/briansmith/webpki) from 0.22.1 to 0.22.2.
- [Commits](https://github.com/briansmith/webpki/commits)

---
updated-dependencies:
- dependency-name: webpki
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* update webpki in license-tool.toml

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pavlos Rontidis <[email protected]>
Bumps [warp](https://github.com/seanmonstar/warp) from 0.3.5 to 0.3.6.
- [Release notes](https://github.com/seanmonstar/warp/releases)
- [Changelog](https://github.com/seanmonstar/warp/blob/master/CHANGELOG.md)
- [Commits](seanmonstar/warp@v0.3.5...v0.3.6)

---
updated-dependencies:
- dependency-name: warp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…18726)

* Revert "fix(debian platform): Remove `conf-files` directive for `cargo-deb` (#18455)"

This reverts commit 40ef7c4.

* Update Cargo.toml
* fix(datadog_metrics sink): improve aggregation performance

* fix tests and add concurrency

* feedback

* add comment to dedupe_by

* sort by metric type as well

* fix flakey proptest

* only dedupe non-counters in prop test
@jszwedko jszwedko requested review from a team and dsmith3197 as code owners October 27, 2023 23:02
@jszwedko jszwedko requested a review from a team October 27, 2023 23:02
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 3cc27b9
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/653fc9ec45fd6b0008c08a00

@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: ci Anything related to Vector's CI environment domain: releasing Anything related to releasing Vector domain: external docs Anything related to Vector's external, public documentation labels Oct 27, 2023
neuronull and others added 5 commits October 27, 2023 16:03
* fix(dnstap source): support DNSSEC RRSIG record data

* update codeowners
…er queue is full (#18770)

* fix(kafka sink): set concurrency limits equal to kafka producer queue limits

* use send_result to better track state

* nits

* clippy
* chore(ci): Add a test to assert conf files aren't overwritten

Signed-off-by: Jesse Szwedko <[email protected]>

* shell check

Signed-off-by: Jesse Szwedko <[email protected]>

---------

Signed-off-by: Jesse Szwedko <[email protected]>
* chore(ci): Bump MacOS unit test runners to 13

Signed-off-by: Jesse Szwedko <[email protected]>

* Trigger on pull_request (temporarily)

Signed-off-by: Jesse Szwedko <[email protected]>

* Remove PR trigger

Signed-off-by: Jesse Szwedko <[email protected]>

---------

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
Copy link
Member Author

/ci-run-all

* chore(ci): Fix cookie banner style issues

Signed-off-by: Jesse Szwedko <[email protected]>

* spelling

Signed-off-by: Jesse Szwedko <[email protected]>

---------

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
Copy link
Member Author

/ci-run-all

@github-actions
Copy link

Regression Detector Results

Run ID: 0932f64a-9151-4e8d-8abf-38efeef8cd3e
Baseline: 70e8b5f
Comparison: a2bb2ee
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment goal Δ mean % confidence
otlp_http_to_blackhole ingress throughput +6.25 100.00%
socket_to_socket_blackhole ingress throughput +5.35 100.00%
Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
syslog_regex_logs2metric_ddmetrics ingress throughput +456.48 [+455.43, +457.52] 100.00%
otlp_http_to_blackhole ingress throughput +6.25 [+6.11, +6.39] 100.00%
socket_to_socket_blackhole ingress throughput +5.35 [+5.29, +5.41] 100.00%
syslog_log2metric_humio_metrics ingress throughput +2.71 [+2.62, +2.80] 100.00%
otlp_grpc_to_blackhole ingress throughput +0.87 [+0.76, +0.97] 100.00%
file_to_blackhole egress throughput +0.86 [-1.74, +3.45] 41.35%
datadog_agent_remap_blackhole ingress throughput +0.79 [+0.70, +0.87] 100.00%
syslog_log2metric_splunk_hec_metrics ingress throughput +0.75 [+0.63, +0.87] 100.00%
syslog_loki ingress throughput +0.66 [+0.62, +0.70] 100.00%
http_text_to_http_json ingress throughput +0.56 [+0.45, +0.68] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput +0.50 [+0.42, +0.58] 100.00%
syslog_humio_logs ingress throughput +0.47 [+0.41, +0.54] 100.00%
datadog_agent_remap_blackhole_acks ingress throughput +0.22 [+0.14, +0.31] 100.00%
http_to_http_noack ingress throughput +0.14 [+0.03, +0.25] 96.55%
syslog_splunk_hec_logs ingress throughput +0.08 [+0.04, +0.13] 99.63%
http_to_s3 ingress throughput +0.03 [-0.24, +0.30] 15.01%
splunk_hec_route_s3 ingress throughput +0.02 [-0.47, +0.50] 4.16%
datadog_agent_remap_datadog_logs ingress throughput +0.01 [-0.09, +0.10] 7.25%
http_to_http_json ingress throughput +0.00 [-0.04, +0.05] 11.24%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.15, +0.15] 0.30%
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.14] 0.15%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.14, +0.09] 31.58%
enterprise_http_to_http ingress throughput -0.12 [-0.20, -0.03] 98.08%
fluent_elasticsearch ingress throughput -0.53 [-0.97, -0.10] 95.68%
http_to_http_acks ingress throughput -0.98 [-2.32, +0.37] 76.69%

Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (might be worth getting another stamp for src/sinks changes)

website/cue/reference/releases/0.33.1.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.33.1.cue Outdated Show resolved Hide resolved
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: prepare-v0.33.1
Commit report: 98264cd

vector: 0 Failed, 0 New Flaky, 1971 Passed, 0 Skipped, 1m 18.43s Wall Time

@jszwedko
Copy link
Member Author

/ci-run-all

Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, noted in a comment.

This patch release contains fixes for regressions in 0.33.0 and fixes an issues with the Debian release artifacts.

**Note:** Please see the release notes for [`v0.33.0`](/releases/0.33.0/) for additional changes if upgrading from
`v0.32.X`. In particular, the upgrade guide for breaking changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`v0.32.X`. In particular, the upgrade guide for breaking changes.
`v0.32.X`. In particular, see the upgrade guide for breaking changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I opened #18987 to follow up on this.

@jszwedko jszwedko merged commit 3cc27b9 into v0.33 Oct 30, 2023
75 checks passed
@jszwedko jszwedko deleted the prepare-v0.33.1 branch October 30, 2023 18:28
type: "fix"
scopes: ["kafka source"]
description: """
A performance regression in the `kafka` source was corrected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed component is kafka sink, not source

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! I opened #19032 to correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation domain: releasing Anything related to releasing Vector domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants