Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(kubernetes): add support for include_paths_glob_patterns #19521

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Jan 5, 2024

In addition to the existing exclude_paths_glob_patterns configuration option in the kubernetes source, it would be useful to be able to limit the set of candidate logs with the include_paths_glob_patterns option, evaluated first.

@syedriko syedriko requested review from a team as code owners January 5, 2024 04:59
@syedriko syedriko requested a review from a team January 5, 2024 04:59
@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: external docs Anything related to Vector's external, public documentation labels Jan 5, 2024
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review needed

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @syedriko ! Apologies for the delay in review. Do you mind adding a changelog fragment?

@syedriko syedriko force-pushed the syedriko-k8s-include-paths-glob-patterns branch from 445e69b to d6a7927 Compare February 11, 2024 04:03
@syedriko
Copy link
Contributor Author

Thanks for this @syedriko ! Apologies for the delay in review. Do you mind adding a changelog fragment?

Done.

@jszwedko
Copy link
Member

Thanks!

@jszwedko jszwedko enabled auto-merge February 12, 2024 14:37
auto-merge was automatically disabled February 13, 2024 19:41

Head branch was pushed to by a user without write access

@syedriko syedriko force-pushed the syedriko-k8s-include-paths-glob-patterns branch 2 times, most recently from 84efa01 to d703dd3 Compare February 15, 2024 04:25
@jszwedko jszwedko enabled auto-merge February 15, 2024 14:40
auto-merge was automatically disabled February 15, 2024 14:57

Head branch was pushed to by a user without write access

@syedriko syedriko force-pushed the syedriko-k8s-include-paths-glob-patterns branch from d703dd3 to 87cfecb Compare February 15, 2024 14:57
@jszwedko jszwedko enabled auto-merge February 15, 2024 14:58
auto-merge was automatically disabled February 15, 2024 16:24

Head branch was pushed to by a user without write access

@syedriko syedriko force-pushed the syedriko-k8s-include-paths-glob-patterns branch from 87cfecb to 4b5860a Compare February 15, 2024 16:24
@jszwedko jszwedko enabled auto-merge February 15, 2024 17:22
@jszwedko jszwedko added this pull request to the merge queue Feb 15, 2024
Copy link

Regression Detector Results

Run ID: 8e6a84d1-92ed-4282-ae01-4df0cf0da3b9
Baseline: f920675
Comparison: a7fe0db
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_blackhole ingress throughput +3.90 [+3.79, +4.01]
file_to_blackhole egress throughput +3.11 [+0.63, +5.59]
syslog_regex_logs2metric_ddmetrics ingress throughput +2.90 [+2.78, +3.01]
socket_to_socket_blackhole ingress throughput +2.02 [+1.95, +2.09]
syslog_log2metric_humio_metrics ingress throughput +1.92 [+1.78, +2.07]
syslog_humio_logs ingress throughput +1.83 [+1.72, +1.94]
datadog_agent_remap_datadog_logs ingress throughput +1.15 [+1.05, +1.25]
otlp_http_to_blackhole ingress throughput +1.07 [+0.93, +1.21]
syslog_splunk_hec_logs ingress throughput +1.01 [+0.96, +1.07]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.98 [+0.90, +1.07]
syslog_loki ingress throughput +0.32 [+0.26, +0.38]
splunk_hec_route_s3 ingress throughput +0.24 [-0.27, +0.74]
http_to_http_noack ingress throughput +0.07 [-0.01, +0.15]
http_to_http_json ingress throughput +0.05 [-0.03, +0.12]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.16, +0.16]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
http_elasticsearch ingress throughput -0.03 [-0.10, +0.04]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.05 [-0.16, +0.06]
enterprise_http_to_http ingress throughput -0.10 [-0.19, -0.01]
http_to_s3 ingress throughput -0.19 [-0.47, +0.09]
fluent_elasticsearch ingress throughput -0.25 [-0.74, +0.23]
datadog_agent_remap_blackhole_acks ingress throughput -0.45 [-0.55, -0.34]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.46 [-0.61, -0.31]
http_text_to_http_json ingress throughput -0.48 [-0.60, -0.36]
http_to_http_acks ingress throughput -0.56 [-1.87, +0.74]
otlp_grpc_to_blackhole ingress throughput -1.17 [-1.26, -1.09]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -1.31 [-1.44, -1.18]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into vectordotdev:master with commit a7fe0db Feb 15, 2024
50 checks passed
@jszwedko
Copy link
Member

Thanks for this contribution @syedriko !

@syedriko
Copy link
Contributor Author

Thanks for this contribution @syedriko !

Any time!

AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants