-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(kubernetes_logs source): Added offset key to the same as in file.rs #22203
base: master
Are you sure you want to change the base?
enhancement(kubernetes_logs source): Added offset key to the same as in file.rs #22203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shahar-I-levy, this mostly looks good! Please add a changelog fragment. You can find our guide here.
@pront Added changelog fragment :) |
@pront Hi, can you please assist me with the PR? |
Hello @shahar-I-levy, there are two changelog files. Can you |
@pront Hi, what additional steps should be done? |
There are some failing CI checks. I recommending iterating locally with |
Summary
Change Type
Is this a breaking change?
How did you test this PR?
I've built this version and it runs on my dev environments with the expected behaviour like in file.rs
running tests locally failed. I went through the testing locally doc shared with me but make 'check-all' failed with the message:
error: failed to run custom build command for
vector-core v0.1.0 (/Users/shaharlevy/data-general/git-repos/vector/lib/vector-core)
Caused by:
process didn't exit successfully:
/Users/shaharlevy/data-general/git-repos/vector/target/debug/build/vector-core-ed3459ea862b01a0/build-script-build
(exit status: 101)--- stdout
cargo:rerun-if-changed=proto/event.proto
--- stderr
thread 'main' panicked at lib/vector-core/build.rs:11:10:
called
Result::unwrap()
on anErr
value: Custom { kind: NotFound, error: "Could not findprotoc
. Ifprotoc
is installed, try setting thePROTOC
environment variable to the path of theprotoc
binary. To install it on macOS, runbrew install protobuf
. It is also available at https://github.com/protocolbuffers/protobuf/releases For more information: https://docs.rs/prost-build/#sourcing-protoc" }note: run with
RUST_BACKTRACE=1
environment variable to display a backtracewarning: build failed, waiting for other jobs to finish...
Error: command: cd "/Users/shaharlevy/data-general/git-repos/vector" && "cargo" "clippy" "--workspace" "--all-targets" "--no-default-features" "--features" "default,all-integration-tests" "--" "-D" "warnings"
failed with exit code: 101
make: *** [check-clippy] Error 1
Does this PR include user facing changes?