Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(kubernetes_logs source): Added offset key to the same as in file.rs #22203

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shahar-I-levy
Copy link

@shahar-I-levy shahar-I-levy commented Jan 14, 2025

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance
  • Enhancement

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

I've built this version and it runs on my dev environments with the expected behaviour like in file.rs

running tests locally failed. I went through the testing locally doc shared with me but make 'check-all' failed with the message:

error: failed to run custom build command for vector-core v0.1.0 (/Users/shaharlevy/data-general/git-repos/vector/lib/vector-core)

Caused by:
process didn't exit successfully: /Users/shaharlevy/data-general/git-repos/vector/target/debug/build/vector-core-ed3459ea862b01a0/build-script-build (exit status: 101)
--- stdout
cargo:rerun-if-changed=proto/event.proto

--- stderr
thread 'main' panicked at lib/vector-core/build.rs:11:10:
called Result::unwrap() on an Err value: Custom { kind: NotFound, error: "Could not find protoc. If protoc is installed, try setting the PROTOC environment variable to the path of the protoc binary. To install it on macOS, run brew install protobuf. It is also available at https://github.com/protocolbuffers/protobuf/releases For more information: https://docs.rs/prost-build/#sourcing-protoc" }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
Error: command: cd "/Users/shaharlevy/data-general/git-repos/vector" && "cargo" "clippy" "--workspace" "--all-targets" "--no-default-features" "--features" "default,all-integration-tests" "--" "-D" "warnings"
failed with exit code: 101
make: *** [check-clippy] Error 1

Does this PR include user facing changes?

  • No. A maintainer will apply the "no-changelog" label to this PR.

@shahar-I-levy shahar-I-levy requested a review from a team as a code owner January 14, 2025 19:25
@bits-bot
Copy link

bits-bot commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Jan 14, 2025
@pront pront changed the title Added offset key to kubernetes logs the same as in file.rs en(kubernetes_logs): Added offset key to the same as in file.rs Jan 14, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahar-I-levy, this mostly looks good! Please add a changelog fragment. You can find our guide here.

@pront pront self-assigned this Jan 16, 2025
@shahar-I-levy
Copy link
Author

shahar-I-levy commented Jan 17, 2025

@pront Added changelog fragment :)

@pront pront changed the title en(kubernetes_logs): Added offset key to the same as in file.rs enhancement(kubernetes_logs): Added offset key to the same as in file.rs Jan 17, 2025
@pront pront changed the title enhancement(kubernetes_logs): Added offset key to the same as in file.rs enhancement(kubernetes_logs source): Added offset key to the same as in file.rs Jan 17, 2025
@shahar-I-levy
Copy link
Author

@pront Hi, can you please assist me with the PR?
What else is needed?
I added the changelog file but not sure it's ok

@pront pront requested a review from a team January 21, 2025 20:03
@pront
Copy link
Member

pront commented Jan 21, 2025

@pront Hi, can you please assist me with the PR? What else is needed? I added the changelog file but not sure it's ok

Hello @shahar-I-levy, there are two changelog files. Can you git rm one?

@shahar-I-levy
Copy link
Author

@pront Hi, what additional steps should be done?

@pront
Copy link
Member

pront commented Jan 24, 2025

@pront Hi, what additional steps should be done?

There are some failing CI checks. I recommending iterating locally with make check-all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants