Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more remap examples for remap conditions #6219

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

binarylogic
Copy link
Contributor

Signed-off-by: binarylogic [email protected]

Signed-off-by: binarylogic <[email protected]>
@binarylogic binarylogic requested a review from bruceg as a code owner January 25, 2021 00:23
@binarylogic binarylogic changed the title Add more remap examples chore: Add more remap examples for remap conditions Jan 25, 2021
Copy link
Contributor

@jamtur01 jamtur01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spelling issue.

]
},
{
title: "Reduce Rails logs into a signle transaction"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single

marge_strategies: message: "concat_newline"
starts_when: {
type: "remap"
source: 'match(.message, /^[^\s]/)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this \s need an extra \ in the Cue source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. It was necessary when using non-literal strings in TOML, hence the ' characters.

Signed-off-by: binarylogic <[email protected]>
Signed-off-by: binarylogic <[email protected]>
@binarylogic binarylogic merged commit 5eb327d into master Jan 25, 2021
@binarylogic binarylogic deleted the fix-cue-examples branch January 25, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants