Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remap transform): Add parse_common_log function #6230

Merged
merged 10 commits into from
Feb 5, 2021
Merged

feat(remap transform): Add parse_common_log function #6230

merged 10 commits into from
Feb 5, 2021

Conversation

pablosichert
Copy link
Contributor

Closes #5370.

@pablosichert pablosichert force-pushed the pablosichert/remap-function-parse-common-log branch 2 times, most recently from fab966a to 8b35bdc Compare January 30, 2021 13:26
@pablosichert pablosichert force-pushed the pablosichert/remap-function-parse-common-log branch 4 times, most recently from 10fa2c9 to fc82d00 Compare January 30, 2021 22:53
@pablosichert pablosichert marked this pull request as ready for review January 30, 2021 23:36
@pablosichert pablosichert requested review from a team and StephenWakely and removed request for a team January 30, 2021 23:36
StephenWakely
StephenWakely requested changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple of minor changes.

lib/remap-functions/src/parse_common_log.rs Outdated Show resolved Hide resolved
lib/remap-functions/src/parse_common_log.rs Show resolved Hide resolved
lib/remap-functions/src/parse_common_log.rs Outdated Show resolved Hide resolved
@pablosichert
feat(remap transform): Add parse_common_log function
20832df 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Remove dependency and use regex to parse common log
bb04ad4 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Make timestamp format configurable through additional parameter
4c0722f 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Adjust error message style similar to other remap functions
97d9e1f 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Add docs for the parse_common_log function
935c2d0 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Make field names of common log message more concise
ac279b7 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Add behavioral test for parse_common_log remap function
a7e2783 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Allow dynamic values for timestamp_format instead of literals
c01186b 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Mark as parse_common_log always fallible
69b485f 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert
Add inner type definition
3718f82 
Signed-off-by: Pablo Sichert <[email protected]>
@pablosichert pablosichert force-pushed the pablosichert/remap-function-parse-common-log branch from deb5293 to 3718f82 Compare February 5, 2021 14:45
StephenWakely
StephenWakely approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@pablosichert pablosichert merged commit fe17fe4 into master Feb 5, 2021
@pablosichert pablosichert deleted the pablosichert/remap-function-parse-common-log branch February 5, 2021 18:08
@pablosichert pablosichert mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarylogic binarylogic binarylogic left review comments

@StephenWakely StephenWakely StephenWakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New parse_common_log Remap function
3 participants
@pablosichert @StephenWakely @binarylogic