chore(remap, external docs): Document compile-time errors #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: binarylogic <[email protected]>
binarylogic
requested review from
a team and
pablosichert
and removed request for
a team
Signed-off-by: binarylogic <[email protected]>
Signed-off-by: binarylogic <[email protected]>
Signed-off-by: binarylogic <[email protected]>
Signed-off-by: binarylogic <[email protected]>
pablosichert
approved these changes
Feb 3, 2021
docs/reference/remap/errors/106_function_argument_arity_mismatch.cue
Outdated
Show resolved
Hide resolved
docs/reference/remap/errors/107_required_function_argument_missing.cue
Outdated
Show resolved
Hide resolved
docs/reference/remap/errors/108_unknown_function_argument_keyword.cue
Outdated
Show resolved
Hide resolved
JeanMertz
approved these changes
Feb 3, 2021
docs/reference/remap/errors/108_unknown_function_argument_keyword.cue
Outdated
Show resolved
Hide resolved
Comment on lines
+53
to
+55
| +if is_string(.message) { | ||
| downcase(.message) | ||
| + } |
There was a problem hiding this comment.
This doesn't work yet. I'm not certain if we're tracking this in an issue yet, I believe we are? cc @FungusHumungus.
Comment on lines
46
to
47
| +string!(.message) | ||
| downcase(.message) |
There was a problem hiding this comment.
This doesn't work, because you still have to assign the result of the string call to have the compiler deduce the type:
.message = string!(.message)
downcase(.message)or:
downcase(string!(.message))While technically the current example could be made to work, I'm hesitant to do so, as it would mean one of two things:
- we'd have to special-case
string(etc) functions (basically converting them to a function-like built-in) to allow manipulating compiler type state, or - allow functions in general to manipulate type state, which I suspect would be a recipe for breaking core language safety guarantees by loading a badly implemented function.
Co-authored-by: Pablo Sichert <[email protected]>
Signed-off-by: binarylogic <[email protected]>
…ch.cue Co-authored-by: Pablo Sichert <[email protected]>
…sing.cue Co-authored-by: Pablo Sichert <[email protected]>
…ord.cue Co-authored-by: Pablo Sichert <[email protected]>
Co-authored-by: Pablo Sichert <[email protected]>
Co-authored-by: Pablo Sichert <[email protected]>
…ord.cue Co-authored-by: Jean Mertz <[email protected]>
Signed-off-by: binarylogic <[email protected]>
|
Thanks for the reviews. We will circle back and update the examples before launching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: binarylogic [email protected]