enhancement(remap): improved type definitions for or
with nullable fields
#6462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #6344 - I've updated it to work with the recent parser changes.
Following from #6182, a number of functions return fields that can be
Null
, for exampleappname
fromparse_syslog
can beKind::Bytes | Kind::Null
.This PR makes it possible to specify a default value using Or. Since we know that if the lhs is either Null or Bytes, we can deduce that the whole expression
lhs | rhs
will either be thelhs - Kind::Null
or therhs
.Eg. This now typechecks:
However this will still not typecheck, the
procid
field can be either a string, an integer or null. So even after an Or it could still be an Integer or a String.:Signed-off-by: Stephen Wakely [email protected]