enhancement: batch events out metric in Pipeline #8383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toby Lawrence <[email protected]>
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: b809ec6 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/60f705d7a5aff6000817fbf5 |
spencergilbert
approved these changes
Jul 20, 2021
blt
approved these changes
Jul 20, 2021
Signed-off-by: Toby Lawrence <[email protected]>
jdrouet
pushed a commit
that referenced
this pull request
Jul 23, 2021
* enhancement: batch events out metric in Pipeline Signed-off-by: Toby Lawrence <[email protected]>
jaysonsantos
pushed a commit
to jaysonsantos/vector
that referenced
this pull request
Aug 1, 2021
* enhancement: batch events out metric in Pipeline Signed-off-by: Toby Lawrence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of incrementing
events_out_total-- viaemit!(EventOut { .. })-- every time we get an event inPipeline, we instead batch the updates and flush them out inPipeline::try_flush. For high events/second configurations, this can provide a significant reduction in metric emissions overall.Signed-off-by: Toby Lawrence [email protected]