New Templates Added #19

CDPhu · 2022-10-01T13:49:42Z

fixes #7
I have compiled a list of 5 new templates.
@vedant-jain03, Please tell me if I need to change anything within them

netlify · 2022-10-01T13:49:46Z

❌ Deploy Preview for adoring-allen-cc4d44 failed.

Name	Link
🔨 Latest commit	`06b291e`
🔍 Latest deploy log	https://app.netlify.com/sites/adoring-allen-cc4d44/deploys/633ee12442425e000867b920

yashikajotwani12

@LostButton This is not the way of adding templates, kindly refer to the current templates implementation. It is way more then just adding images, let me know if you have any doubt!!!

yashikajotwani12

Hey @LostButton, You need to add your templates here.
https://github.com/vedant-jain03/certificate-generator/blob/master/src/components/Homepage.jsx#L156
I did tried adding and I saw this where the headings were merging, so after adding make sure everything is working.

Add and let me know if you need any help, Good work 👍

CDPhu · 2022-10-04T03:04:44Z

@yashikajotwani12 The tenplate should be fixed now

CDPhu · 2022-10-05T01:04:52Z

It should be formatted properly now, if not please alert me so i can fix any issues.

yashikajotwani12 · 2022-10-05T16:47:55Z

Hey @LostButton, you have not added your templates like it is added here

certificate-generator/src/components/Homepage.jsx

Line 156 in 8e3021a

, please add the code in Homepage.jsx.

CDPhu · 2022-10-05T16:51:48Z

Hey @LostButton, you have not added your templates like it is added here

certificate-generator/src/components/Homepage.jsx

Line 156 in 8e3021a

<img src={template4} alt="" />

, please add the code in Homepage.jsx.

But jsx is already updated. It was updated during my second commit?

CDPhu · 2022-10-05T16:55:58Z

OHHHHH I SEE NOW

yashikajotwani12 · 2022-10-05T17:17:07Z

ScreenRecorder_2022-10-05_20640a3d-f7f7-4a9a-890a-31b7a255f239.mp4

The template when clicked just blanks out the screen, please do check this.

CDPhu · 2022-10-05T17:58:29Z

Can you please check whether its only template seven this is happening to?

CDPhu · 2022-10-05T18:29:48Z

Of all things, it was a single space. Issue should be patched now

CDPhu · 2022-10-06T00:41:05Z

@yashikajotwani12 The issue of the blank page should be patched now

yashikajotwani12 · 2022-10-06T02:59:31Z

Also the size of the templates is bigger, you can add a scrolling part so that the size remains the same.

After your changes:

vedant-jain03

You are almost there, here are some changes you need to take care of and then we are finally merging this. Great Work @LostButton 💯

Also you can make scrolling effect by raising new issues. That don't need to add in this PR. WDYT @yashikajotwani12 ?

src/components/Homepage.jsx

vedant-jain03 · 2022-10-06T05:12:50Z

Also the size of the templates is bigger, you can add a scrolling part so that the size remains the same. After your changes:

Could you please add a new issue for this after we merge this PR, the context of the PR was just to add templates.
WDYT @yashikajotwani12 ?

CDPhu · 2022-10-06T12:11:19Z

@vedant-jain03 Is this ok?

src/components/Homepage.jsx

+                            <h2 style={{ fontSize: '12px', color: '#781114', textDecoration: 'underline', textTransform: 'uppercase' }}>Course Director</h2>
+                            <h1 style={{ fontSize: '20px', color: '#0300b0', textTransform: 'uppercase' }}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1>
+                        </div>
+                        {this.props.logo === '' ? "" : <img src={this.props.logo} style={{ position: 'absolute', width: '6rem', borderRadius: '50%', top: '20%', left: '35%' }} alt="logo" />}


src/components/Homepage.jsx

+                            <h2 style={{ fontSize: '12px', color: 'white', textDecoration: 'underline' }}>Course Director</h2>
+                            <h1 style={{ fontSize: '20px', color: '#ffff58', fontWeight: '100'}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1>
+                        </div>
+                        {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />}


src/components/Homepage.jsx

+                            <h2 style={{ fontSize: '12px', color: 'red', textDecoration: 'underline' }}>Course Director</h2>
+                            <h1 style={{ fontSize: '20px', color: 'black',}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1>
+                        </div>
+                        {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />}


src/components/Homepage.jsx

+                            <h2 style={{ fontSize: '12px', color: '#c929ff', textDecoration: 'underline' }}>Course Director</h2>
+                            <h1 style={{ fontSize: '20px', color: 'rgb(19, 22, 207)',}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1>
+                        </div>
+                        {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />}


src/components/Homepage.jsx

+                            <h2 style={{ fontSize: '12px', color: '#0edee6', textDecoration: 'underline' }}>Course Director</h2>
+                            <h1 style={{ fontSize: '20px', color: 'rgb(6, 124, 214)',}}>{this.props.author === '' ? 'Author Name' : this.props.author}</h1>
+                        </div>
+                        {this.props.logo === '' ? '' : <img src={this.props.logo} style={{ position: 'absolute', width: '4rem', borderRadius: '50%', top: '10%', left: '45%' }} alt="logo" />}


yashikajotwani12 · 2022-10-06T13:51:50Z

Hey @LostButton, As suggested by @vedant-jain03 we would open a new issue for the scrolling, but the one thing that I checked is this, do you see the same?

ScreenRecorder_2022-10-06_14bcb6ea-b7c5-4bfb-909f-acd90acd31be.mp4

Else Everything is fine.

CDPhu · 2022-10-06T14:08:57Z

@yashikajotwani12 The issue should be fixed. a small redirection error but it should be fixed

yashikajotwani12 · 2022-10-06T14:12:44Z

Yeah! It is fixed @LostButton, It LGTM.
Good Work 👍

vedant-jain03

@LostButton Great work, 💯
Thanks for your valuable contribution!

New Templates

cca9f9b

yashikajotwani12 requested changes Oct 2, 2022

View reviewed changes

jsx updated

0e62ace

CDPhu requested a review from yashikajotwani12 October 3, 2022 01:03

yashikajotwani12 requested changes Oct 3, 2022

View reviewed changes

fixing template

c134f14

CDPhu requested a review from yashikajotwani12 October 3, 2022 13:07

Template Display

193b91e

fixing template7

65aaf9b

spacing issue

2205e9d

vedant-jain03 requested changes Oct 6, 2022

View reviewed changes

src/components/Homepage.jsx Outdated Show resolved Hide resolved

src/components/Homepage.jsx Outdated Show resolved Hide resolved

src/components/Homepage.jsx Outdated Show resolved Hide resolved

src/components/Homepage.jsx Outdated Show resolved Hide resolved

CDPhu added 2 commits October 6, 2022 08:07

As per author requested

7ce3473

fixing gif

553f459

CDPhu requested review from vedant-jain03 and removed request for yashikajotwani12 October 6, 2022 12:10

github-advanced-security bot found potential problems Oct 6, 2022

View reviewed changes

CDPhu removed the request for review from vedant-jain03 October 6, 2022 13:34

CDPhu requested a review from yashikajotwani12 October 6, 2022 13:34

fixing redirect template 9

06b291e

yashikajotwani12 approved these changes Oct 6, 2022

View reviewed changes

CDPhu requested a review from vedant-jain03 October 6, 2022 14:26

vedant-jain03 approved these changes Oct 6, 2022

View reviewed changes

vedant-jain03 merged commit 11f9bf8 into vedant-jain03:master Oct 6, 2022

vedant-jain03 added the hacktoberfest-accepted For valid merged PR label Oct 6, 2022

Shardul-Kavar mentioned this pull request Oct 6, 2022

user can now upload logo from storage #20

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Templates Added #19

New Templates Added #19

CDPhu commented Oct 1, 2022 •

edited by vedant-jain03

Loading

netlify bot commented Oct 1, 2022 •

edited

Loading

yashikajotwani12 left a comment •

edited

Loading

yashikajotwani12 left a comment •

edited

Loading

CDPhu commented Oct 4, 2022 •

edited

Loading

CDPhu commented Oct 5, 2022

yashikajotwani12 commented Oct 5, 2022

CDPhu commented Oct 5, 2022

CDPhu commented Oct 5, 2022

yashikajotwani12 commented Oct 5, 2022

CDPhu commented Oct 5, 2022

CDPhu commented Oct 5, 2022 •

edited

Loading

CDPhu commented Oct 6, 2022

yashikajotwani12 commented Oct 6, 2022

vedant-jain03 left a comment •

edited

Loading

vedant-jain03 commented Oct 6, 2022

CDPhu commented Oct 6, 2022

yashikajotwani12 commented Oct 6, 2022

CDPhu commented Oct 6, 2022

yashikajotwani12 commented Oct 6, 2022 •

edited

Loading

vedant-jain03 left a comment

New Templates Added #19

New Templates Added #19

Conversation

CDPhu commented Oct 1, 2022 • edited by vedant-jain03 Loading

netlify bot commented Oct 1, 2022 • edited Loading

❌ Deploy Preview for adoring-allen-cc4d44 failed.

yashikajotwani12 left a comment • edited Loading

Choose a reason for hiding this comment

yashikajotwani12 left a comment • edited Loading

Choose a reason for hiding this comment

CDPhu commented Oct 4, 2022 • edited Loading

CDPhu commented Oct 5, 2022

yashikajotwani12 commented Oct 5, 2022

CDPhu commented Oct 5, 2022

CDPhu commented Oct 5, 2022

yashikajotwani12 commented Oct 5, 2022

CDPhu commented Oct 5, 2022

CDPhu commented Oct 5, 2022 • edited Loading

CDPhu commented Oct 6, 2022

yashikajotwani12 commented Oct 6, 2022

vedant-jain03 left a comment • edited Loading

Choose a reason for hiding this comment

vedant-jain03 commented Oct 6, 2022

CDPhu commented Oct 6, 2022

yashikajotwani12 commented Oct 6, 2022

CDPhu commented Oct 6, 2022

yashikajotwani12 commented Oct 6, 2022 • edited Loading

vedant-jain03 left a comment

Choose a reason for hiding this comment

CDPhu commented Oct 1, 2022 •

edited by vedant-jain03

Loading

netlify bot commented Oct 1, 2022 •

edited

Loading

yashikajotwani12 left a comment •

edited

Loading

yashikajotwani12 left a comment •

edited

Loading

CDPhu commented Oct 4, 2022 •

edited

Loading

CDPhu commented Oct 5, 2022 •

edited

Loading

vedant-jain03 left a comment •

edited

Loading

yashikajotwani12 commented Oct 6, 2022 •

edited

Loading