docs: fix example in window.md #8611
Conversation
I think this fixes although I can't test on my machine to be certain: #8610 Also minor wording updates.
site/docs/transform/window.md
Outdated
|
|
||
| ### Percent of Total | ||
|
|
||
| You can use the window transform to compute an aggregate and attach it to all records. In this case, you can use the [join aggregate](joinaggregate.html) instead of the window transform. Please refer to the [join aggregate examples](joinaggregate.html#examples). | ||
|
|
||
| Here we use the window transform to derive the global sum so that we can calculate percentage. | ||
|
|
||
| <div class="vl-example" data-name="window_percent_of_total"></div> | ||
| <div class="vl-example" data-name="joinaggregate_percent_of_total"></div> |
There was a problem hiding this comment.
Thanks for the fix. We already have a separate page for join aggregate at https://vega.github.io/vega-lite/docs/joinaggregate.html so I don't think we should have this example here. Can you fund the correct example, add it back, or update the text?
There was a problem hiding this comment.
Ah, you're right. I think the original example was removed to be replaced with a simpler joinaggregate here: #4554
Maybe we should just delete the section altogether now it is covered by joinaggregate.
There was a problem hiding this comment.
I have updated to remove some redundancy and simplify the text.
There was a problem hiding this comment.
Maybe we leave things up to line 124 with the link but delete the rest.
Removed redundant example
|
Can you run prettier? |
Unfortunately not as I don't have an environment set up. I'm editing on the web. I can't see why prettier would fail as it looks clean and is a simple line of text with not much to actually format. |
|
Thank you |
|
🚀 PR was released in |
* Update window.md I think this fixes although I can't test on my machine to be certain: vega#8610 Also minor wording updates. * Update window.md Removed redundant example * Update window.md * Update site/docs/transform/window.md * style: prettier Co-authored-by: Dominik Moritz <[email protected]>
I think this fixes the following although I can't test on my machine to be certain: #8610
Also minor wording update.