ship_view.py: Fix a few things, best I can figure out #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
evertvorster
approved these changes
Jan 15, 2025
BenjamenMeyer
approved these changes
Jan 16, 2025
| try: | ||
| fl = float(ship_stats[key])/divider | ||
| except KeyError: | ||
| print('KeyError in get_dbl: ', key, ' not found in ship_stats') |
There was a problem hiding this comment.
FYI - since we're using Py3 we can use f-Strings here we makes formatting really nice and easy:
print(f'KeyError in get_dbl: {key} not found in ship_stats')
There was a problem hiding this comment.
Should it be f"blurb" and not f'blurb'?
There was a problem hiding this comment.
@royfalk it doesn't really matter which; typically you use one if you want to use the other:
f"blurb 'b' "
f'blurb "b" 'they both denote a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes:
Issues:
Purpose: