-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker-it
by @whisklabs
#305
Conversation
README.md
Outdated
@@ -150,6 +150,7 @@ _Source:_ [What is Docker](https://www.docker.com/what-docker) | |||
* [bocker](https://github.com/p8952/bocker) (1) - Docker implemented in 100 lines of bash by [p8952](https://github.com/p8952) | |||
* [construi](https://github.com/lstephen/construi) - Run your builds inside a Docker defined environment by [@lstephen](https://github.com/lstephen) | |||
* [Docker Client for JVM](https://github.com/gesellix/docker-client) - A Docker remote api client library for the JVM, written in Groovy by [@gesellix][gesellix] | |||
* [docker-it](https://github.com/whisklabs/docker-it-scala) - Docker integration testing kit with Scala by [@whisklabs](https://github.com/whisklabs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @agebhar1 I noticed the name is slightly different that the project. Could you please rename the project to docker-it-scale according to the GitHub project? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vegasbrianc sure will rename it. My fault ;)
Hi @agebhar1 Looks like a great tool. Once the name is updated according to my review we can merge this. Thanks! |
4ecd002
to
fe1e75c
Compare
@vegasbrianc - fixed it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@agebhar1 well done! If you are interested, would you like to become a maintainer? |
thx @veggiemonk - and yes I'm interested :) |
@agebhar1 invite sent 👍 welcome. few things you have to know:
Anyway welcome to the team, if you have any questions, please ask (use the chat, or twitter or whatever feels more confortable for you) |
No description provided.