Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker-it by @whisklabs #305

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

agebhar1
Copy link
Collaborator

@agebhar1 agebhar1 commented Apr 1, 2017

No description provided.

README.md Outdated
@@ -150,6 +150,7 @@ _Source:_ [What is Docker](https://www.docker.com/what-docker)
* [bocker](https://github.com/p8952/bocker) (1) - Docker implemented in 100 lines of bash by [p8952](https://github.com/p8952)
* [construi](https://github.com/lstephen/construi) - Run your builds inside a Docker defined environment by [@lstephen](https://github.com/lstephen)
* [Docker Client for JVM](https://github.com/gesellix/docker-client) - A Docker remote api client library for the JVM, written in Groovy by [@gesellix][gesellix]
* [docker-it](https://github.com/whisklabs/docker-it-scala) - Docker integration testing kit with Scala by [@whisklabs](https://github.com/whisklabs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @agebhar1 I noticed the name is slightly different that the project. Could you please rename the project to docker-it-scale according to the GitHub project? Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vegasbrianc sure will rename it. My fault ;)

@vegasbrianc
Copy link
Collaborator

Hi @agebhar1 Looks like a great tool. Once the name is updated according to my review we can merge this. Thanks!

@agebhar1 agebhar1 force-pushed the feature/docker-it branch from 4ecd002 to fe1e75c Compare April 3, 2017 17:58
@agebhar1
Copy link
Collaborator Author

agebhar1 commented Apr 3, 2017

@vegasbrianc - fixed it :)

Copy link
Owner

@veggiemonk veggiemonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veggiemonk veggiemonk merged commit c11e65e into veggiemonk:master Apr 3, 2017
@veggiemonk
Copy link
Owner

@agebhar1 well done!

If you are interested, would you like to become a maintainer?

@agebhar1 agebhar1 deleted the feature/docker-it branch April 3, 2017 19:18
@agebhar1
Copy link
Collaborator Author

agebhar1 commented Apr 3, 2017

thx @veggiemonk - and yes I'm interested :)

@veggiemonk
Copy link
Owner

@agebhar1 invite sent 👍 welcome.

few things you have to know:

  • we don't push directly to master, we create a pull request.
  • how to tell if a project should be on the list, read CONTRIBUTING.md
  • to ask a contributor to make a change, just copy paste this message here and changes a few things like names and stuff. The main idea is to help people get to quality.
  • If something seems weird, if you don't understand what a project does or the documentation is poor, don't hesitate to ask for more (see previous point).

Anyway welcome to the team, if you have any questions, please ask (use the chat, or twitter or whatever feels more confortable for you)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants