Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Whales #366

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Add Whales #366

merged 1 commit into from
Jul 3, 2017

Conversation

mayra-cabrera
Copy link
Contributor

@mayra-cabrera mayra-cabrera commented Jun 27, 2017

Project: https://github.com/Gueils/whales

Description: Whales is a tool to automatically dockerize your applications. It works as command line interface that tames the Belugas features analyzers and outputs necessary Docker files to run your application with Docker

@mayra-cabrera mayra-cabrera changed the title Add Whales tools Add Whales Jun 27, 2017
Whales is a tool to automatically dockerize your applications.
It works as command line interface that tames the
features analyzers and outputs necessary Docker files to run your application with Docker

Made with love by IcaliaLabs: https://github.com/IcaliaLabs
@moshloop
Copy link
Collaborator

Why is this awesome? It has only 3 contributors and a handful of stars?

@veggiemonk
Copy link
Owner

@mayra-cabrera I see you've put some work into that project and it shows.
Now the examples are a bit inconsistent, sometimes the images is whalesil/whales:latest but in the GIF the image is acalialabs/whales. That confuses people.
Also it would be nice to explain some of those parameters and what they are meant for.
The "usage" section needs more work!

We value people's time a lot so we want them to find the best projects there is.
Our goals is also to help developers to make great projects.
So a good start would be to look at other projects and take good ideas from them.
Docker-sync has a very simple website hosted on github pages, that really improves the reach of the project (more people come and check it out). http://docker-sync.io/
Some developers go really the extra miles to explain what their project is all about such as https://github.com/grammarly/rocker

So let us know if you need any help. Then come back here and ping us. All right?
Once you do that, the project will be on the list for sure!

Have a good day and keep on making great software!

The awesome docker team

@vegasbrianc @gesellix @dmitrytokarev @devhkr @Moshe-Immerman @veggiemonk

@Moshe-Immerman you should talk nicely to people, especially if you don't want to see your maintainer's right revoked! You are here to help people, not to judge them!
Read the contribution guidelines before dismissing a project and this #289 (comment)

Copy link
Owner

@veggiemonk veggiemonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the usage section needs more work

@@ -256,6 +256,7 @@ Services to securely store your Docker images.
* [portainer](https://github.com/duedil-ltd/portainer) - Apache Mesos framework for building Docker images by [@duedil-ltd](https://github.com/duedil-ltd)
* [rocker](https://github.com/grammarly/rocker) - Extended Dockerfile builder. Supports multiple FROMs, MOUNTS, templates, etc. by [grammarly](grammarly).
* [SkinnyWhale](https://github.com/djosephsen/skinnywhale) Skinnywhale helps you make smaller (as in megabytes) Docker containers.
* [Whales](https://github.com/Gueils/whales) - A tool to automatically dockerize your applications by [@icalialabs](https://github.com/IcaliaLabs).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, nice project! see the comment for improvements

@agebhar1
Copy link
Collaborator

Sounds interesting @mayra-cabrera! Beside @veggiemonk hints the link to 'Belugas Java' is broken.

@moshloop
Copy link
Collaborator

moshloop commented Jun 28, 2017

@mayra-cabrera I hope you didn't take offense to my terse reply - it certainly wasn't intended that way. May I suggest that you also post a blog or 2 about the project and how it came about so that you can get some more eyes on it?
@veggiemonk thanks I have saved the comment as reply template for future

@veggiemonk
Copy link
Owner

@Moshe-Immerman No worries. I'm glad you are on board with us :D

@mayra-cabrera
Copy link
Contributor Author

@veggiemonk @agebhar1 @Moshe-Immerman thanks for your suggestions! I'll get back to you once I'm done with the changes

@mayra-cabrera
Copy link
Contributor Author

hey @veggiemonk @agebhar1 @Moshe-Immerman thanks for your patience.

We follow your suggestions and improve the readme outline by adding the following sections: "How does it work", "Architecture" & "Command explanation": https://github.com/Gueils/whales. I hope is more consistent and gives you a better idea of what the project is all about.

Also to make it more friendly and reach more people, we create a website for it: http://www.whales.mx

What do you think? Is this ready to be merged? :)

@agebhar1
Copy link
Collaborator

Hey @mayra-cabrera thank you for your improvements! I can earliest have a look at Sunday. Maybe one of the other team members @veggiemonk @devhkr @vegasbrianc @gesellix @Moshe-Immerman can have a look.

@veggiemonk
Copy link
Owner

@mayra-cabrera good work.

@veggiemonk veggiemonk merged commit ff4d8bc into veggiemonk:master Jul 3, 2017
@mayra-cabrera mayra-cabrera deleted the whales branch July 3, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants