clean warnings

.nuke/build.csproj

@@ -11,6 +11,7 @@
     <IsPackable>false</IsPackable>
     <EnablePreviewFeatures>true</EnablePreviewFeatures>
     <InvariantGlobalization>true</InvariantGlobalization>
+    <WarningLevel>0</WarningLevel>
   </PropertyGroup>
 
   <ItemGroup>

Directory.Build.props

@@ -27,6 +27,7 @@
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+    <NoWarn>CS0162,CS8981,CS8632,CS9113,CS8618,CS9113,CS8321,CS0219,CS1998,IDE0053</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>

lib/ast/syntax/DocumentDeclaration.cs

@@ -26,17 +26,16 @@ public string Name
 
         public NamespaceSymbol Namespace => new(Name);
 
-        public IEnumerable<DirectiveSyntax> Directives { get; set; }
-        public IEnumerable<MemberDeclarationSyntax> Members { get; set; }
+        public IEnumerable<DirectiveSyntax> Directives { get; init; }
+        public IEnumerable<MemberDeclarationSyntax> Members { get; init; }
         public IEnumerable<AspectDeclarationSyntax> Aspects { get; set; }
-        public IEnumerable<AliasSyntax> Aliases { get; set; }
+        public IEnumerable<AliasSyntax> Aliases { get; init; }
         public FileInfo FileEntity { get; set; }
         public string SourceText { get; set; }
         public string[] SourceLines => SourceText.Replace("\r", "").Split("\n");
 
         private List<NamespaceSymbol>? _includes;
 
-        public int[]? _line_offsets;
 
         public List<NamespaceSymbol> Includes => _includes ??= Directives.OfExactType<UseSyntax>().Select(x =>
         {

lib/ast/syntax/ast/MemberDeclarationSyntax.cs

@@ -9,7 +9,7 @@ public class MemberDeclarationSyntax : BaseSyntax, IPositionAware<MemberDeclarat
     {
         public MemberDeclarationSyntax() { }
 
-        public MemberDeclarationSyntax(MemberDeclarationSyntax other = null)
+        public MemberDeclarationSyntax(MemberDeclarationSyntax? other = null)
             => this.WithProperties(other);
         public override SyntaxType Kind => SyntaxType.ClassMember;
 

lib/ast/syntax/ast/PropertyDeclarationSyntax.cs

@@ -1,6 +1,7 @@
 namespace vein.syntax;
 
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Linq;
 
 public class PropertyDeclarationSyntax(MemberDeclarationSyntax? heading = null) : MemberDeclarationSyntax(heading)
@@ -11,14 +12,22 @@ public PropertyDeclarationSyntax(IEnumerable<AccessorDeclarationSyntax> accessor
 
     public override SyntaxType Kind => SyntaxType.Property;
 
-    public override IEnumerable<BaseSyntax> ChildNodes =>
-        base.ChildNodes.Concat(GetNodes(Type, Getter, Setter, Expression));
+    public override IEnumerable<BaseSyntax> ChildNodes
+    {
+        get
+        {
+            Debug.Assert(Getter != null, nameof(Getter) + " != null");
+            Debug.Assert(Setter != null, nameof(Setter) + " != null");
+            Debug.Assert(Expression != null, nameof(Expression) + " != null");
+            return base.ChildNodes.Concat(GetNodes(Type, Getter, Setter, Expression));
+        }
+    }
 
     public TypeSyntax Type { get; set; }
 
     public IdentifierExpression Identifier { get; set; }
 
-    public List<AccessorDeclarationSyntax> Accessors { get; set; } = new();
+    public List<AccessorDeclarationSyntax> Accessors { get; init; } = new();
 
     public AccessorDeclarationSyntax? Getter => Accessors.FirstOrDefault(a => a.IsGetter);
 
@@ -27,10 +36,10 @@ public PropertyDeclarationSyntax(IEnumerable<AccessorDeclarationSyntax> accessor
     public override MemberDeclarationSyntax WithTypeAndName(ParameterSyntax typeAndName)
     {
         Type = typeAndName.Type;
-        Identifier = typeAndName.Identifier ?? typeAndName.Type.Identifier;
+        Identifier = typeAndName.Identifier;
         return this;
     }
-    public ExpressionSyntax? Expression { get; set; }
+    public ExpressionSyntax? Expression { get; init; }
 
     public bool IsShortform() => Getter is null && Setter is null && Expression is not null;
 

lib/ast/syntax/ast/expressions/IdentifierExpression.cs

@@ -1,48 +1,47 @@
-namespace vein.syntax
+namespace vein.syntax;
+
+using System;
+using runtime;
+using Sprache;
+
+public sealed class IdentifierExpression : ExpressionSyntax, IPositionAware<IdentifierExpression>, IEquatable<IdentifierExpression>
 {
-    using System;
-    using runtime;
-    using Sprache;
+    public IdentifierExpression(string name) : base(name)
+        => this.ExpressionString = name;
 
-    public class IdentifierExpression : ExpressionSyntax, IPositionAware<IdentifierExpression>, IEquatable<IdentifierExpression>
+    public new IdentifierExpression SetPos(Position startPos, int length)
     {
-        public IdentifierExpression(string name) : base(name)
-            => this.ExpressionString = name;
-
-        public new IdentifierExpression SetPos(Position startPos, int length)
-        {
-            base.SetPos(startPos, length);
-            return this;
-        }
-
-        public bool Equals(IdentifierExpression other)
-        {
-            if (other is null)
-                return false;
-            return this.ExpressionString == other.ExpressionString;
-        }
-
-        public override bool Equals(object obj)
-        {
-            if (ReferenceEquals(null, obj)) return false;
-            if (ReferenceEquals(this, obj)) return true;
-            if (obj.GetType() != this.GetType()) return false;
-            return Equals((IdentifierExpression)obj);
-        }
-
-        public override int GetHashCode()
-            => this.ExpressionString.GetHashCode();
-
-        public static bool operator ==(IdentifierExpression left, IdentifierExpression right)
-            => Equals(left, right);
-
-        public static bool operator !=(IdentifierExpression left, IdentifierExpression right)
-            => !Equals(left, right);
-
-        public override string ToString() =>
-            ExpressionString;
-
-        public static implicit operator string(IdentifierExpression i) => i.ToString();
-        public static implicit operator IdentifierExpression(NameSymbol s) => new(s.name);
+        base.SetPos(startPos, length);
+        return this;
     }
+
+    public bool Equals(IdentifierExpression? other)
+    {
+        if (other is null)
+            return false;
+        return this.ExpressionString == other.ExpressionString;
+    }
+
+    public override bool Equals(object? obj)
+    {
+        if (ReferenceEquals(null, obj)) return false;
+        if (ReferenceEquals(this, obj)) return true;
+        if (obj.GetType() != this.GetType()) return false;
+        return Equals((IdentifierExpression)obj);
+    }
+
+    public override int GetHashCode()
+        => this.ExpressionString!.GetHashCode();
+
+    public static bool operator ==(IdentifierExpression left, IdentifierExpression right)
+        => Equals(left, right);
+
+    public static bool operator !=(IdentifierExpression left, IdentifierExpression right)
+        => !Equals(left, right);
+
+    public override string ToString() =>
+        ExpressionString;
+
+    public static implicit operator string(IdentifierExpression i) => i.ToString();
+    public static implicit operator IdentifierExpression(NameSymbol s) => new(s.name);
 }

lib/ast/syntax/ast/expressions/SyntaxExtensions.cs

@@ -7,50 +7,50 @@ namespace vein.syntax
 
     public static class SyntaxExtensions
     {
-        public static T WithLeadingComments<T>(this T syntax, IEnumerable<string> comments)
+        public static T? WithLeadingComments<T>(this T syntax, IEnumerable<string>? comments)
             where T : BaseSyntax
         {
             if (comments != null)
                 syntax?.LeadingComments.AddRange(comments);
             return syntax;
         }
 
-        public static T WithLeadingComment<T>(this T syntax, string comment)
+        public static T? WithLeadingComment<T>(this T syntax, string? comment)
             where T : BaseSyntax
         {
             if (comment != null)
                 syntax?.LeadingComments.Add(comment);
             return syntax;
         }
 
-        public static T WithTrailingComments<T>(this T syntax, IEnumerable<string> comments)
+        public static T? WithTrailingComments<T>(this T syntax, IEnumerable<string>? comments)
             where T : BaseSyntax
         {
             if (comments != null)
                 syntax?.TrailingComments.AddRange(comments);
             return syntax;
         }
 
-        public static T WithTrailingComment<T>(this T syntax, string comment)
+        public static T? WithTrailingComment<T>(this T syntax, string? comment)
             where T : BaseSyntax
         {
             if (comment != null)
                 syntax?.TrailingComments.Add(comment);
             return syntax;
         }
 
-        public static BlockSyntax WithInnerComments(this BlockSyntax syntax, IEnumerable<string> comments)
+        public static BlockSyntax WithInnerComments(this BlockSyntax syntax, IEnumerable<string>? comments)
         {
             if (comments != null)
-                syntax?.InnerComments.AddRange(comments);
+                syntax.InnerComments.AddRange(comments);
 
             return syntax;
         }
 
         public static BlockSyntax WithInnerComment(this BlockSyntax syntax, params string[] comments) =>
             syntax.WithInnerComments(comments);
 
-        public static ClassDeclarationSyntax WithInnerComments(this ClassDeclarationSyntax syntax, IEnumerable<string> comments)
+        public static ClassDeclarationSyntax? WithInnerComments(this ClassDeclarationSyntax? syntax, IEnumerable<string>? comments)
         {
             var s = new List<int>();
 
@@ -64,10 +64,10 @@ public static ClassDeclarationSyntax WithInnerComments(this ClassDeclarationSynt
             return syntax;
         }
 
-        public static ClassDeclarationSyntax WithInnerComment(this ClassDeclarationSyntax syntax, params string[] comments) =>
+        public static ClassDeclarationSyntax? WithInnerComment(this ClassDeclarationSyntax syntax, params string[] comments) =>
             syntax.WithInnerComments(comments);
 
-        public static T WithProperties<T>(this T syntax, MemberDeclarationSyntax other = null)
+        public static T? WithProperties<T>(this T? syntax, MemberDeclarationSyntax? other = null)
             where T : MemberDeclarationSyntax
         {
             if (other == null || syntax == null)

lib/projectsystem/VeinProject.cs

@@ -33,7 +33,7 @@ internal VeinProject(FileInfo file, YAML.Project project)
     public string Name { get; }
     public DirectoryInfo WorkDir { get; }
     public FileInfo ProjectFile { get; }
-    public DirectoryInfo CacheDir => new DirectoryInfo(Path.Combine(WorkDir.FullName, "obj"));
+    public DirectoryInfo CacheDir => new(Path.Combine(WorkDir.FullName, "obj"));
 
     public bool Packable => _project.Packable ?? false;
     public bool IsWorkload => _project.HasWorkload ?? false;
@@ -43,7 +43,7 @@ internal VeinProject(FileInfo file, YAML.Project project)
     public string License => _project.License;
     public PackageUrls Urls => _project.Urls;
 
-    public NuGetVersion Version => new NuGetVersion(_project.Version);
+    public NuGetVersion Version => new(_project.Version);
 
     public IReadOnlyCollection<FileInfo> Sources => WorkDir
         .EnumerateFiles("*.vein", SearchOption.AllDirectories)

lib/projectsystem/Workload.cs

@@ -71,7 +71,7 @@ public record WorkloadManifest
 
 
     public static async Task<WorkloadManifest> OpenAsync(FileInfo bin)
-        => JsonConvert.DeserializeObject<WorkloadManifest>(await bin.ReadToEndAsync());
+        => JsonConvert.DeserializeObject<WorkloadManifest>(await bin.ReadToEndAsync())!;
 
     public string SaveAsString() =>
         JsonConvert.SerializeObject(this, new JsonSerializerSettings()

lib/vein.cli.core/SecurityStorage.cs

@@ -40,7 +40,7 @@ public static void AddKey<T>(string key, T value)
     {
         var store = ReadStorage();
 
-        store[key] = JToken.FromObject(value);
+        store[key] = JToken.FromObject(value!);
 
         Save(store);
     }
@@ -64,7 +64,7 @@ private static Dictionary<string, JToken> ReadStorage()
             if (!ConfigFile.Exists)
                 return new Dictionary<string, JToken>();
             var content = ConfigFile.ReadToEnd();
-            return JsonConvert.DeserializeObject<Dictionary<string, JToken>>(BlowfishDecrypt(content));
+            return JsonConvert.DeserializeObject<Dictionary<string, JToken>>(BlowfishDecrypt(content))!;
         }
         catch
         {

runtime/common/reflection/VeinClass.cs

@@ -310,8 +310,7 @@ public VeinClass ResolveGenericType(VeinComplexType type)
         }
 
         public virtual bool Equals(VeinClass other) => FullName.Equals(other?.FullName);
-
-
+        public override int GetHashCode() => FullName!.GetHashCode();
 
 
         public VeinClass CreateAmorphousVersion(List<VeinClass> generics)

runtime/ishtar.base/emit/ClassBuilder.cs

@@ -12,9 +12,9 @@ namespace ishtar.emit
 
     public record ClassBuilder : VeinClass, IBaker
     {
-        internal VeinModuleBuilder moduleBuilder;
+        internal readonly VeinModuleBuilder moduleBuilder;
 
-        public List<NamespaceSymbol> Includes { get; set; } = new();
+        public List<NamespaceSymbol> Includes { get; set; } = [];
 
         internal ClassBuilder WithIncludes(List<NamespaceSymbol> includes)
         {
@@ -57,7 +57,7 @@ internal ClassBuilder(VeinModuleBuilder module, QualityTypeName name, VeinClass
         /// Method name will be interned.
         /// </remarks>
         public MethodBuilder DefineMethod(string name, VeinComplexType returnType, params VeinArgumentRef[] args)
-            => DefineMethod(name, returnType, new List<VeinTypeArg>(), args);
+            => DefineMethod(name, returnType, [], args);
 
         /// <summary>
         /// Define method in current class.
@@ -84,7 +84,7 @@ public MethodBuilder DefineMethod(string name, VeinComplexType returnType, List<
         /// </remarks>
         public MethodBuilder DefineMethod(string name, MethodFlags flags, VeinComplexType returnType,
             params VeinArgumentRef[] args) =>
-            DefineMethod(name, flags, returnType, new List<VeinTypeArg>(), args);
+            DefineMethod(name, flags, returnType, [], args);
 
         /// <summary>
         /// Define method in current class.
@@ -139,7 +139,7 @@ public VeinProperty DefineAutoProperty(string name, FieldFlags flags, VeinClass
                 ];
 
             var getter =
-                DefineMethod(VeinProperty.GetterFnName(name), VeinProperty.ConvertShadowFlags(flags), propType, new List<VeinTypeArg>(), args);
+                DefineMethod(VeinProperty.GetterFnName(name), VeinProperty.ConvertShadowFlags(flags), propType, [], args);
             if (!IsAbstract)
             {
                 if (flags.HasFlag(FieldFlags.Static))
@@ -196,7 +196,7 @@ public VeinProperty DefineEmptyProperty(string name, FieldFlags flags, VeinClass
         byte[] IBaker.BakeByteArray()
         {
             if (Methods.Count == 0 && Fields.Count == 0)
-                return Array.Empty<byte>();
+                return [];
             using var mem = new MemoryStream();
             using var binary = new BinaryWriter(mem);
 
@@ -232,12 +232,12 @@ string IBaker.BakeDebugString()
             if (IsInterface) str.Append($".interface ");
             else if (IsValueType) str.Append($".struct ");
             else str.Append($".class ");
-            str.Append($"'{FullName.Name}' {Flags.EnumerateFlags(new[] { ClassFlags.None, ClassFlags.Interface }).Join(' ').ToLowerInvariant()}");
+            str.Append($"'{FullName.Name}' {Flags.EnumerateFlags([ClassFlags.None, ClassFlags.Interface]).Join(' ').ToLowerInvariant()}");
             str.AppendLine($" extends {Parents.Select(x => $"'{x.Name}'").Join(", ")}");
             str.AppendLine("{");
             foreach (var field in Fields)
             {
-                var flags = field.Flags.EnumerateFlags(new [] {FieldFlags.None}).Join(' ').ToLowerInvariant();
+                var flags = field.Flags.EnumerateFlags([FieldFlags.None]).Join(' ').ToLowerInvariant();
                 str.AppendLine($"\t.field '{field.Name}' as '{field.FieldType.ToTemplateString()}' {flags}");
             }
             foreach (var method in Methods.OfType<IBaker>().Select(method => method.BakeDebugString()))
@@ -274,6 +274,8 @@ protected override VeinMethod GetOrCreateTor(string name, bool isStatic = false)
             => throw new NotImplementedException();
 
         public virtual bool Equals(ClassBuilder other) => FullName.Equals(other?.FullName);
+        public override int GetHashCode() => FullName!.GetHashCode();
+
         public override string ToString() => base.ToString();
     }
 }