upgrade golang.org/x/tools to fix a panic in go 1.22 #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
Unit tests on master fail on Go 1.22, but work on 1.21.
After the fix, both compilers are happy.
Narrowed it down to an internal panic in golang.org/x/tools, after upgrading to latest version of the lib and doing a
go mod tidy
, the crash went away. The lowest x/tools version that works is 1.13.Checklist