Fix issue with file ordering #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug exists in the logic that determines if `go.mod` exists: if a `*.go` file is returned by the filesystem before `go.mod`, we will not skip the subtree as intended. To fix this, we always stat for `go.mod` if we find a `*.go` file, as a final check before considering the path to be a subpackage.
I don't really like coverage tests because it's kind of faulty. Lots of e2e tests aren't registered in the coverage file, and thus codecov erroneously says we have less coverage than we really do. I'll make this more permissive so it'll not fail the PR checks, but still have it as a PR check just as a reference tool.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #760 +/- ##
===================================================
+ Coverage 42.42613% 42.45067% +0.02454%
===================================================
Files 61 61
Lines 4806 4815 +9
===================================================
+ Hits 2039 2044 +5
- Misses 2588 2591 +3
- Partials 179 180 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug exists in the logic that determines if
go.modexists: if a*.gofile is returned by the filesystem beforego.mod, we will not skip the subtree as intended. To fix this, we always stat forgo.modif we find a*.gofile, as a final check before considering the path to be a subpackage.