Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Fix: Ignore sub packages regex is not adhered #890

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

Orbsynated
Copy link

@Orbsynated Orbsynated commented Jan 9, 2025

Description

The current implementation checks the ignored sub packages regex on the packages that are configured in the config file(when recursive: True), but not on their sub-packages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

  1. I created a .mockery.yaml file and ran it against a package which has sub-packages(using recursive: True option).
  2. I added a regex(using exclude-subpkg-regex to ignore those sub-packages).
  3. Before my fix the sub-packages which were excluded were still being ran on. After which, they were not.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp
Copy link
Collaborator

Woops! That's an oversight. Thank you!

@LandonTClipp LandonTClipp merged commit 85c4718 into vektra:v3 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants