Bugfix/remove description newlines #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-krug-greenphire
force-pushed
the
bugfix/remove_description_newlines
branch
from
f891885 to
47cb440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, I cannot get Payment Processor to start locally. When I try, it crashes on trying to install the business-rules module with this stacktrace:
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [27 lines of output]
running egg_info
creating /tmp/pip-pip-egg-info-u43l4gv1/business_rules.egg-info
writing /tmp/pip-pip-egg-info-u43l4gv1/business_rules.egg-info/PKG-INFO
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/tmp/pip-install-eilfpxqn/business-rules_95814487dd4b423085e3d1b98a88cb19/setup.py", line 12, in
setuptools.setup(
File "/usr/local/lib/python3.9/site-packages/setuptools/init.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/usr/local/lib/python3.9/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/local/lib/python3.9/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/local/lib/python3.9/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.9/site-packages/setuptools/command/egg_info.py", line 292, in run
writer(self, ep.name, os.path.join(self.egg_info, ep.name))
File "/usr/local/lib/python3.9/site-packages/setuptools/command/egg_info.py", line 656, in write_pkg_info
metadata.write_pkg_info(cmd.egg_info)
File "/usr/local/lib/python3.9/distutils/dist.py", line 1117, in write_pkg_info
self.write_pkg_file(pkg_info)
File "/usr/local/lib/python3.9/site-packages/setuptools/dist.py", line 167, in write_pkg_file
write_field('Summary', single_line(self.get_description()))
File "/usr/local/lib/python3.9/site-packages/setuptools/dist.py", line 151, in single_line
raise ValueError('Newlines are not allowed')
ValueError: Newlines are not allowed
Digging into this more, this is due to a change in Python's setuptools from 2021:
pypa/setuptools#2870
This PR mirrors the change that Venmo made in March 2022 to address presumably the same error that I'm getting by removing newlines from their description and adding a long_description property.
b5c1a3c#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7