Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cookies): use Headers#getSetCookie when available #540

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Aug 18, 2023

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

🦋 Changeset detected

Latest commit: e307de1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@edge-runtime/primitives Patch
@edge-runtime/cookies Patch
@edge-runtime/node-utils Patch
@edge-runtime/types Patch
@edge-runtime/vm Patch
@edge-runtime/jest-environment Patch
edge-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
edge-runtime ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 10:19am

@balazsorban44 balazsorban44 changed the title fix(ts): expose Headers#getSetCookie type fix(cookies): use Headers#getSetCookie when available Sep 4, 2023
package.json Outdated Show resolved Hide resolved
@Kikobeats Kikobeats merged commit fb34f31 into vercel:main Sep 5, 2023
@github-actions github-actions bot mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.getSetCookie() and .get('set-cookie') methods are both broken on headers()
2 participants