Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Stop retrying when fetch throws ERR_UNESCAPED_CHARACTERS error #37

Merged
merged 1 commit into from
Oct 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ function setup(fetch) {
return res;
}
} catch (err) {
const isRetry = attempt <= retryOpts.retries;
debug(`${method} ${url} error (${err.status}). ${isRetry ? 'retrying' : ''}`, err);
const isClientError = err && err.code === 'ERR_UNESCAPED_CHARACTERS';
const isRetry = !isClientError && attempt <= retryOpts.retries;
debug(`${method} ${url} error (status = ${err.status}). ${isRetry ? 'retrying' : ''}`, err);
if (isClientError) {
return bail(err);
}
throw err;
}
}, retryOpts);
Expand Down
18 changes: 18 additions & 0 deletions test.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
const assert = require('assert');
const {createServer} = require('http');
const setup = require('./index');

Expand Down Expand Up @@ -145,3 +146,20 @@ test('stops retrying when the Retry-After header exceeds the maxRetryAfter optio
server.on('error', reject);
});
});

test('stops retrying when fetch throws `ERR_UNESCAPED_CHARACTERS` error', async () => {
const opts = {
onRetry: jest.fn(),
}

let err;
try {
await retryFetch(`http://127.0.0.1/\u0019`, opts);
} catch (_err) {
err = _err;
}

assert(err);
assert.equal(err.code, 'ERR_UNESCAPED_CHARACTERS');
assert.equal(opts.onRetry.mock.calls.length, 0);
});