Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8cache experimental flag #112

Merged
merged 6 commits into from
Jan 18, 2019
Merged

v8cache experimental flag #112

merged 6 commits into from
Jan 18, 2019

Conversation

guybedford
Copy link
Contributor

Fixes #51.

Usage is ncc build x.js --v8-cache or the v8cache: true option for the API.

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #112 into master will decrease coverage by 0.6%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   69.86%   69.25%   -0.61%     
==========================================
  Files          16       16              
  Lines         657      670      +13     
==========================================
+ Hits          459      464       +5     
- Misses        198      206       +8
Impacted Files Coverage Δ
src/cli.js 0% <ø> (ø) ⬆️
src/loaders/relocate-loader.js 97.05% <ø> (-0.02%) ⬇️
src/index.js 68.79% <50%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94a2d8...949574f. Read the comment docs.

@guybedford guybedford force-pushed the v8-cache branch 2 times, most recently from c17638b to fd312d2 Compare December 6, 2018 11:59
@guybedford guybedford force-pushed the v8-cache branch 2 times, most recently from 55b09a4 to 054c273 Compare December 21, 2018 22:44
@rauchg rauchg added the wip label Dec 22, 2018
@guybedford
Copy link
Contributor Author

Rebased.

While the build files look pretty ugly, this improves the self-build startup time by around 100ms on my machine.

@guybedford guybedford removed the wip label Jan 9, 2019
@guybedford
Copy link
Contributor Author

The wrapper being used here was conflicting with Jest's Node hooks, so I've updated to a more robust wrapper approach.

@guybedford guybedford force-pushed the v8-cache branch 2 times, most recently from 09bcab4 to e5f40e4 Compare January 15, 2019 17:30
@guybedford guybedford force-pushed the v8-cache branch 3 times, most recently from 28da385 to 9f1f355 Compare January 18, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants