Chromeless fix (#192) #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=======================================
+ Coverage 69.59% 70% +0.4%
=======================================
Files 13 13
Lines 661 670 +9
=======================================
+ Hits 460 469 +9
Misses 201 201
Continue to review full report at Codecov.
|
guybedford
force-pushed
the
chromeless
branch
from
6e0436e to
41b72e0
Compare
guybedford
force-pushed
the
chromeless
branch
from
41b72e0 to
3b2be82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Chromeless build using a very simple boolean inlining approach.
We have to be quite careful with this not to inline the wrong booleans (say there was a process.env check that evaluates to false in the build but will evaluate to true in production). So this is just restricted to the specific trigger cases around assets.