Disable run --watch #259
Merged
Disable run --watch #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 74.29% 74.23% -0.06%
==========================================
Files 17 17
Lines 883 885 +2
==========================================
+ Hits 656 657 +1
- Misses 227 228 +1
Continue to review full report at Codecov.
|
guybedford
commented
Jan 31, 2019
| } | ||
|
|
||
| function errFlagNotCompatible (flag, cmd) { | ||
| nccError(`Error: ${flag} flag is not compatible with ncc ${cmd}\n${usage}`); | ||
| nccError(`Error: ${flag} flag is not compatible with ncc ${cmd}\n${usage}`, 2); |
There was a problem hiding this comment.
I've extended the use of the 2 exit code here for CLI validation errors, as was provided for the help output already.
I'm not sure who implemented this code in the first place, but it seems a useful separation and helps to work with the code-based tests, but I can certainly remove it too and move this to an integration test rather as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a proper error message on the
ncc run --watchcase, which otherwise has some edge cases around signal handling that need to be worked out to fully support this. Some discussion on this is in #253, and the feature could certainly be developed further if desired.