Separate asset relocator #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
asset-relocator-separation
branch
from
978f434 to
a4f293e
Compare
guybedford
force-pushed
the
asset-relocator-separation
branch
from
a4f293e to
011afbe
Compare
guybedford
force-pushed
the
asset-relocator-separation
branch
from
011afbe to
0683722
Compare
guybedford
force-pushed
the
asset-relocator-separation
branch
from
0683722 to
aa5808e
Compare
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
- Coverage 75.08% 66.57% -8.52%
==========================================
Files 17 11 -6
Lines 915 350 -565
==========================================
- Hits 687 233 -454
+ Misses 228 117 -111
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the separate asset relocator loader project.
It requires git credentials to work while that is still an unpublished private repo, so this shouldn't merge until that project has been released.
Note that the asset relocator project itself shouldn't be considered stable / release-worthy until the asset references have been tested fully in new integrations, as there will be bugs with relative asset paths.Fixed up in vercel/webpack-asset-relocator-loader@8ed36c6.