Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run -f as the default #265

Merged
merged 1 commit into from
Feb 1, 2019
Merged

run -f as the default #265

merged 1 commit into from
Feb 1, 2019

Conversation

guybedford
Copy link
Contributor

This avoids the annoying message about left-over temporary build files on previous ncc run calls, and just always attempts to remove these files on ncc run.

This also avoids the need for the PR #258.

@codecov-io
Copy link

Codecov Report

Merging #265 into master will increase coverage by 0.16%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #265      +/-   ##
=========================================
+ Coverage   74.23%   74.4%   +0.16%     
=========================================
  Files          17      17              
  Lines         885     883       -2     
=========================================
  Hits          657     657              
+ Misses        228     226       -2
Impacted Files Coverage Δ
src/cli.js 60.38% <50%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61dcf6c...e07db7d. Read the comment docs.

@rauchg rauchg merged commit 290f7f8 into master Feb 1, 2019
@rauchg rauchg deleted the run-f-default branch February 1, 2019 16:04
@adamelliotfields
Copy link

Just pulled it down - working great with Nodemon so far.

Thanks @guybedford and @rauchg for the quick patch. I hope to contribute more in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants