Update jugglingdb to 2.0.1 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Mar 6, 2019
@guybedford I broke it 😞 I'm not sure what the original use case was here. Should we continue testing the old version and add a new test for the new version? 🤔 |
|
Tests are failing |
|
I've reported on this case here - #303. |
|
I've just pushed an update to the asset relocator loader here, which goes with the approach (1) described in #303. This does have some minor perf cost (roughly 5%), but allows this case to be built and handled properly, ensuring we only build one copy of jugglingdb. |
guybedford
force-pushed
the
update-jugglingdb
branch
from
1c8f43d to
8c9a0de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential security vulnerability.
Related to 1602/jugglingdb#460
Fixes: #303