Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS test to Circle CI #312

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Add MacOS test to Circle CI #312

merged 3 commits into from
Mar 18, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 15, 2019

Add tests for MacOS and Linux

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   68.71%   68.71%           
=======================================
  Files          12       12           
  Lines         374      374           
=======================================
  Hits          257      257           
  Misses        117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5000f...967b0e7. Read the comment docs.

@styfle styfle requested a review from guybedford March 17, 2019 02:49
@styfle
Copy link
Member Author

styfle commented Mar 17, 2019

@guybedford The error on Circle CI is the same error I see on my Mac.

Please investigate when you have time and then I can merge this PR 😄

@styfle styfle marked this pull request as ready for review March 18, 2019 01:07
@styfle styfle merged commit 264c168 into master Mar 18, 2019
@styfle styfle deleted the circleci-macos branch March 18, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants