Only emit known symlinks #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
known-symlinks
branch
2 times, most recently
from
09c2735 to
398b896
Compare
guybedford
force-pushed
the
known-symlinks
branch
from
398b896 to
f3ce1f8
Compare
|
We've actually got coverage on this through the Tensorflow and Sharp tests, so this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new symlink handling that was added has to integrate with the cache, which means that there is a risk of previously cached symlinks being emitted when they are no longer needed.
To avoid this case, symlinks are filtered to only include symlinks to known assets.
I need to add a test for this still, but wanted to check this approach against CI first.Coverage provided by Tensorflow and Sharp tests.