Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print version from programatic API #325

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Print version from programatic API #325

merged 3 commits into from
Mar 27, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 26, 2019

This will print the ncc version and the file being compiled when using the programmatic API const ncc = require('ncc'). Previously, we were only printing the version when the CLI was used.

I also added quiet so that the programmatic API can enable/disable quiet mode.

@styfle styfle added the enhancement New feature or request label Mar 26, 2019
@styfle styfle requested a review from guybedford as a code owner March 26, 2019 20:25
@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #325 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #325     +/-   ##
=========================================
+ Coverage   69.04%   69.45%   +0.4%     
=========================================
  Files          12       12             
  Lines         378      383      +5     
=========================================
+ Hits          261      266      +5     
  Misses        117      117
Impacted Files Coverage Δ
src/cli.js 63.09% <100%> (+0.22%) ⬆️
src/index.js 71.25% <100%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c035b1e...212275c. Read the comment docs.

@styfle styfle changed the title Print version when using require('ncc') programatic API Print version when using programatic API Mar 27, 2019
@styfle styfle changed the title Print version when using programatic API Print version from programatic API Mar 27, 2019
@styfle styfle merged commit c9a0cfa into master Mar 27, 2019
@styfle styfle deleted the version-api branch March 27, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants