Fix v8-cache asset handling #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
v8-cache-assets
branch
from
f2aeef9 to
8199799
Compare
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 69.55% 69.55%
=======================================
Files 12 12
Lines 381 381
=======================================
Hits 265 265
Misses 116 116
Continue to review full report at Codecov.
|
styfle
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #336.
There was a regression on the v8-cache when asset permissions handling was added. This should have been caught by the self-build, but the self-build was effectively working around the API difference.
Fixes the self-build too and includes and end-to-end test of the v8-cache.