Fix source maps #96
Merged
Fix source maps #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
commented
Dec 3, 2018
| if (run) { | ||
| const ps = require("child_process").fork(outDir + "/index.js", { | ||
| execArgv: map | ||
| ? ["-r", resolve(__dirname, "sourcemap-register")] |
There was a problem hiding this comment.
I changed this into finding a sourcemap-register in the same directory
rauchg
commented
Dec 3, 2018
| @@ -0,0 +1,3 @@ | |||
| // note: this file is overriden by `scripts/build` | |||
| // and substituted for the production release | |||
| module.exports = require("source-map-support/register"); | |||
There was a problem hiding this comment.
This makes it work both inside dist/ and in src/
There was a problem hiding this comment.
Ah, thanks for sorting out this use case too.
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 69.78% 70.85% +1.07%
==========================================
Files 3 4 +1
Lines 331 326 -5
==========================================
Hits 231 231
+ Misses 100 95 -5
Continue to review full report at Codecov.
|
guybedford
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.