Fix domain locales not available on client (#26083)

* bug: Fix domain locales not available on client * Add test case * update tests Co-authored-by: JJ Kasper <[email protected]>
vercel · Jun 22, 2021 · 27d78a5 · 27d78a5
1 parent 005a6e4
commit 27d78a5
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 1 deletion.
diff --git a/packages/next/client/router.ts b/packages/next/client/router.ts
@@ -43,6 +43,7 @@ const urlPropertyFields = [
   'isReady',
   'isPreview',
   'isLocaleDomain',
+  'domainLocales',
 ]
 const routerEvents = [
   'routeChangeStart',

diff --git a/test/integration/build-output/test/index.test.js b/test/integration/build-output/test/index.test.js
@@ -129,7 +129,7 @@ describe('Build Output', () => {
           expect(parseFloat(err404Size)).toBeCloseTo(gz ? 3.17 : 8.51, 1)
           expect(err404Size.endsWith('kB')).toBe(true)
 
-          expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.9 : 204, 1)
+          expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.9 : 205, 1)
           expect(err404FirstLoad.endsWith('kB')).toBe(true)
 
           expect(parseFloat(sharedByAll)).toBeCloseTo(gz ? 63.7 : 196, 1)

diff --git a/test/integration/i18n-support-base-path/pages/index.js b/test/integration/i18n-support-base-path/pages/index.js
@@ -11,6 +11,7 @@ export default function Page(props) {
       <p id="router-locale">{router.locale}</p>
       <p id="router-default-locale">{router.defaultLocale}</p>
       <p id="router-locales">{JSON.stringify(router.locales)}</p>
+      <p id="router-domain-locales">{JSON.stringify(router.domainLocales)}</p>
       <p id="router-query">{JSON.stringify(router.query)}</p>
       <p id="router-pathname">{router.pathname}</p>
       <p id="router-as-path">{router.asPath}</p>

diff --git a/test/integration/i18n-support/pages/index.js b/test/integration/i18n-support/pages/index.js
@@ -11,6 +11,7 @@ export default function Page(props) {
       <p id="router-locale">{router.locale}</p>
       <p id="router-default-locale">{router.defaultLocale}</p>
       <p id="router-locales">{JSON.stringify(router.locales)}</p>
+      <p id="router-domain-locales">{JSON.stringify(router.domainLocales)}</p>
       <p id="router-query">{JSON.stringify(router.query)}</p>
       <p id="router-pathname">{router.pathname}</p>
       <p id="router-as-path">{router.asPath}</p>

diff --git a/test/integration/i18n-support/test/shared.js b/test/integration/i18n-support/test/shared.js
@@ -37,6 +37,21 @@ async function addDefaultLocaleCookie(browser) {
 }
 
 export function runTests(ctx) {
+  it.only('should have domainLocales available on useRouter', async () => {
+    const browser = await webdriver(ctx.appPort, `${ctx.basePath || '/'}`)
+    expect(
+      JSON.parse(await browser.elementByCss('#router-domain-locales').text())
+    ).toEqual([
+      {
+        http: true,
+        domain: 'example.do',
+        defaultLocale: 'do',
+        locales: ['do-BE'],
+      },
+      { domain: 'example.com', defaultLocale: 'go', locales: ['go-BE'] },
+    ])
+  })
+
   it('should not error with similar named cookie to locale cookie', async () => {
     const res = await fetchViaHTTP(
       ctx.appPort,