do not apply sass loader on existing loaders (#50308)

follow up for #50259 --------- Co-authored-by: Justin Ridgewell <[email protected]>
vercel · May 25, 2023 · 46369f5 · 46369f5
1 parent 06f505c
commit 46369f5
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/packages/next-swc/crates/next-core/src/sass.rs b/packages/next-swc/crates/next-core/src/sass.rs
@@ -39,14 +39,19 @@ pub async fn maybe_add_sass_loader(
         };
 
         if let Some(rule) = rule {
+            // Without `as`, loader result would be JS code, so we don't want to apply
+            // sass-loader on that.
+            let Some(rename_as) = rule.rename_as.as_ref() else {
+                continue;
+            };
+            // Only when the result should run through the sass pipeline, we apply
+            // sass-loader.
+            if rename_as != "*" {
+                continue;
+            }
             let mut loaders = rule.loaders.await?.clone_value();
             loaders.push(loader);
             rule.loaders = WebpackLoaderItemsVc::cell(loaders);
-            if let Some(rename_as) = rule.rename_as.as_mut() {
-                rename_as.push_str(rename);
-            } else {
-                rule.rename_as = Some(format!("*{rename}"));
-            }
         } else {
             rules.insert(
                 pattern.to_string(),