-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find type definition file for 'ua-parser-js' since 12.0.5-canary.11 with skipLibCheck set to false #31992
Comments
Hi, this should be fixed in |
The ua-parser-js error is fixed in .13 👍 but now there is a type error in a different file:
|
This ensures type checking passes correctly for middleware types when `skipLibCheck: false` is set in `tsconfig.json`. This also moves the `middleware-types` to be an isolated test to ensure it isn't relying on any monorepo dependencies. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: #31992 (comment)
Hi, the above error should be resolved in |
This ensures type checking passes correctly for middleware types when `skipLibCheck: false` is set in `tsconfig.json`. This also moves the `middleware-types` to be an isolated test to ensure it isn't relying on any monorepo dependencies. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: #31992 (comment)
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
This ensures type checking passes correctly for middleware types when `skipLibCheck: false` is set in `tsconfig.json`. This also moves the `middleware-types` to be an isolated test to ensure it isn't relying on any monorepo dependencies. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: vercel#31992 (comment)
What version of Next.js are you using?
12.0.5-canary.12
What version of Node.js are you using?
17.1.0
What browser are you using?
Any
What operating system are you using?
Windows 10 (10.0.19043 Build 19043)
How are you deploying your application?
next export
Describe the Bug
Since version
12.0.5-canary.11
,next build
fails the typechecking stage whenskipLibCheck
intsconfig.json
is set tofalse
:Expected Behavior
The typecheck should pass when
skipLibCheck
is set tofalse
, like in previous versions.To Reproduce
Create a project and install the canary version of next.js (both
12.0.5-canary.11
and12.0.5-canary.12
reproduce this currently):yarn create next-app --ts . yarn add next@canary
Adjust
tsconfig.json
:Then run
yarn run build
.The text was updated successfully, but these errors were encountered: