Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example(contentful): set up content types with required fields #12591

Merged
merged 2 commits into from
May 20, 2020
Merged

example(contentful): set up content types with required fields #12591

merged 2 commits into from
May 20, 2020

Conversation

taye
Copy link
Contributor

@taye taye commented May 7, 2020

The example app expects all fields of Post and Author entries to be present and fails to build if any are missing. This PR adds a "required" validation to fields of both content types to avoid bulid errors.

CC @stefanjudis

fix(examples/cms-contentful): set up content types with required fields
2249715 
The example app expects all fields of Post and Author entries to be
present and fails to build if any are missing. This PR adds a "required"
validation to fields of both content types to avoid bulid errors.
@taye taye requested review from lfades and Timer as code owners May 7, 2020 10:37
@ijjk
Copy link
Member

ijjk commented May 7, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
buildDuration 11.4s 11.4s ⚠️ +70ms
nodeModulesSize 58.8 MB 58.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.909 1.845 -0.06
/ avg req/sec 1309.46 1354.87 ⚠️ +45.41
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.103 1.1 0
/error-in-render avg req/sec 2265.87 2273.28 ⚠️ +7.41
Client Bundles (main, webpack, commons)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.js gzip 6.23 kB 6.23 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.module.js gzip 4.83 kB 4.83 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
buildDuration 12.2s 12.2s ⚠️ +67ms
nodeModulesSize 58.8 MB 58.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.js gzip 6.23 kB 6.23 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.module.js gzip 4.83 kB 4.83 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓

@stefanjudis
Copy link
Contributor

🎉 LGTM. :)

@Timer Timer added the examples Issue was opened via the examples template. label May 18, 2020
Timer
Timer approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Timer Timer added this to the 9.4.2 milestone May 20, 2020
@Timer Timer changed the title fix(examples/cms-contentful): set up content types with required fields example(contentful): set up content types with required fields May 20, 2020
@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
buildDuration 11.3s 11.3s ⚠️ +6ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.113 1.87 -0.24
/ avg req/sec 1183.08 1336.66 ⚠️ +153.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.241 1.243 0
/error-in-render avg req/sec 2013.99 2011.87 -2.12
Client Bundles (main, webpack, commons)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
buildDuration 12.1s 12s -73ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary taye/next.js fix/examples/cms-contentful/export-required-fields Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@kodiakhq kodiakhq bot merged commit 53b478c into vercel:canary May 20, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@taye @chibicode
example(contentful): set up content types with required fields (verce…
c42630e 
…l#12591)

The example app expects all fields of Post and Author entries to be present and fails to build if any are missing. This PR adds a "required" validation to fields of both content types to avoid bulid errors.

CC @stefanjudis
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@taye @rokinsky
example(contentful): set up content types with required fields (verce…
0a7e029 
…l#12591)

The example app expects all fields of Post and Author entries to be present and fails to build if any are missing. This PR adds a "required" validation to fields of both content types to avoid bulid errors.

CC @stefanjudis
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@taye @ijjk @stefanjudis @Timer