Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize test for Windows #13050

Merged
merged 1 commit into from
May 18, 2020
Merged

Stabilize test for Windows #13050

merged 1 commit into from
May 18, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented May 18, 2020

I noticed this test was flaking out for Windows, so this should fix that.

@Timer Timer added this to the 9.4.2 milestone May 18, 2020
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners May 18, 2020 15:06
@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Timer/next.js no-fixed-wait Change
buildDuration 12s 11.9s -123ms
nodeModulesSize 58.6 MB 58.6 MB
Page Load Tests Overall increase ✓
zeit/next.js canary Timer/next.js no-fixed-wait Change
/ failed reqs 0 0
/ total time (seconds) 1.952 1.98 ⚠️ +0.03
/ avg req/sec 1280.82 1262.89 -17.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.161 1.142 -0.02
/error-in-render avg req/sec 2152.57 2189.78 ⚠️ +37.21
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js no-fixed-wait Change
main-HASH.js gzip 6.71 kB 6.71 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js no-fixed-wait Change
main-HASH.module.js gzip 5.74 kB 5.74 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js no-fixed-wait Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Timer/next.js no-fixed-wait Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Timer/next.js no-fixed-wait Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Timer/next.js no-fixed-wait Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Timer/next.js no-fixed-wait Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Timer/next.js no-fixed-wait Change
buildDuration 12.7s 12.7s ⚠️ +51ms
nodeModulesSize 58.6 MB 58.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js no-fixed-wait Change
main-HASH.js gzip 6.71 kB 6.71 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.1 kB 57.1 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js no-fixed-wait Change
main-HASH.module.js gzip 5.74 kB 5.74 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js no-fixed-wait Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Timer/next.js no-fixed-wait Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Timer/next.js no-fixed-wait Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Timer/next.js no-fixed-wait Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Timer/next.js no-fixed-wait Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@Timer Timer merged commit f5c8b42 into vercel:canary May 18, 2020
@Timer Timer deleted the no-fixed-wait branch May 18, 2020 16:05
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants