Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An empty jsconfig.json should not fail the build #13051

Merged
merged 2 commits into from
May 18, 2020
Merged

An empty jsconfig.json should not fail the build #13051

merged 2 commits into from
May 18, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented May 18, 2020

We have this special cased and tested already for tsconfig.json, so this adjusts the behavior of jsconfig.json to match.

@Timer Timer added this to the 9.4.2 milestone May 18, 2020
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners May 18, 2020 15:15
@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
buildDuration 11.2s 11.5s ⚠️ +261ms
nodeModulesSize 58.6 MB 58.6 MB ⚠️ +72 B
Page Load Tests Overall increase ✓
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.916 1.866 -0.05
/ avg req/sec 1304.85 1339.46 ⚠️ +34.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.248 1.231 -0.02
/error-in-render avg req/sec 2003.92 2031.09 ⚠️ +27.17
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
buildDuration 12s 12.2s ⚠️ +208ms
nodeModulesSize 58.6 MB 58.6 MB ⚠️ +72 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_error.js 850 kB 850 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
buildDuration 13.6s 13.4s -202ms
nodeModulesSize 58.6 MB 58.6 MB ⚠️ +72 B
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.295 2.315 ⚠️ +0.02
/ avg req/sec 1089.33 1079.96 -9.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.487 1.487 ✓
/error-in-render avg req/sec 1680.88 1681.71 ⚠️ +0.83
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
buildDuration 14.2s 14.5s ⚠️ +334ms
nodeModulesSize 58.6 MB 58.6 MB ⚠️ +72 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js fix-empty-tsconfig Change
_error.js 850 kB 850 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@Timer Timer merged commit 6d6ce94 into vercel:canary May 18, 2020
@Timer Timer deleted the fix-empty-tsconfig branch May 18, 2020 16:31
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@Timer @chibicode
An empty jsconfig.json should not fail the build (vercel#13051)
1ad7557
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@Timer @rokinsky
An empty jsconfig.json should not fail the build (vercel#13051)
6c4f9ef
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @ijjk @timneutkens