Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant code from with-portals-ssr example #13060

Merged
merged 4 commits into from
May 19, 2020
Merged

Remove redundant code from with-portals-ssr example #13060

merged 4 commits into from
May 19, 2020

Conversation

todortotev
Copy link
Contributor

The issue is related to 12964

Let me know if there are any changes you want me to make.

@todortotev todortotev requested review from lfades and Timer as code owners May 18, 2020 18:07
@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
buildDuration 12s 12.1s ⚠️ +51ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.974 1.954 -0.02
/ avg req/sec 1266.43 1279.14 ⚠️ +12.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.209 1.206 0
/error-in-render avg req/sec 2068 2072.83 ⚠️ +4.83
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
buildDuration 13.2s 12.9s -313ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_error.js 851 kB 851 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@ijjk

This comment has been minimized.

Sign in to view
@Timer Timer changed the title removed redundant imports and replaced the fragment with the shorthan… Remove redundant code from with-portals-ssr example May 18, 2020
@Timer Timer added the examples Issue was opened via the examples template. label May 18, 2020
@Timer Timer added this to the 9.4.2 milestone May 18, 2020
Timer
Timer requested changes May 18, 2020
View reviewed changes
examples/with-portals-ssr/pages/index.js Outdated Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
buildDuration 13.3s 13.6s ⚠️ +268ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.288 2.285 0
/ avg req/sec 1092.85 1094.12 ⚠️ +1.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.457 1.482 ⚠️ +0.02
/error-in-render avg req/sec 1716.06 1686.46 -29.6
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
buildDuration 14.5s 14.4s -17ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js improve-with-portals-ssr-example Change
_error.js 851 kB 851 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@ijjk
Copy link
Member

ijjk commented May 18, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > should update sass styles using hmr
Expand output

● Configuration › should update sass styles using hmr

expect(received).toBe(expected) // Object.is equality

Expected: "rgba(255, 255, 0, 1)"
Received: "rgba(255, 0, 0, 1)"

  170 |       expect(
  171 |         await browser.elementByCss('.hello-world').getComputedCss('color')
> 172 |       ).toBe('rgba(255, 255, 0, 1)')
      |         ^
  173 | 
  174 |       try {
  175 |         file.replace('yellow', 'red')

  at Object.<anonymous> (integration/config/test/index.test.js:172:9)

@timneutkens timneutkens merged commit fd55ef9 into vercel:canary May 19, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@todortotev @Timer @chibicode
Remove redundant code from with-portals-ssr example (vercel#13060)
9c13617 
* removed redundant imports and replaced the fragment with the shorthand syntax

* Brought back the component import

Co-authored-by: Joe Haddad <[email protected]>
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@todortotev @Timer @rokinsky
Remove redundant code from with-portals-ssr example (vercel#13060)
553e7df 
* removed redundant imports and replaced the fragment with the shorthand syntax

* Brought back the component import

Co-authored-by: Joe Haddad <[email protected]>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer requested changes

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@todortotev @ijjk @Timer @timneutkens