Add error when exporting pages with fallback: true #13063

ijjk · 2020-05-18T19:25:58Z

As discussed this adds an error when next export is run for pages with fallback: true since this is invalid and defeats the functionality that fallback: true provides

errors/ssg-fallback-true-export.md

…back

ijjk · 2020-05-18T19:36:53Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
buildDuration	11.8s	11.6s	-268ms
nodeModulesSize	60.4 MB	60.4 MB	⚠️ +1.03 kB

Page Load Tests Overall increase ✓

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.949	1.887	-0.06
/ avg req/sec	1282.99	1324.93	⚠️ +41.94
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.141	1.113	-0.03
/error-in-render avg req/sec	2190.47	2246.71	⚠️ +56.24

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.js gzip	6.71 kB	6.71 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..fc14.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.module.js gzip	5.74 kB	5.74 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.28 kB	3.28 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.26 kB	8.26 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
buildDuration	11.7s	11.4s	-352ms
nodeModulesSize	60.4 MB	60.4 MB	⚠️ +1.03 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.js gzip	6.71 kB	6.71 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..fc14.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.module.js gzip	5.74 kB	5.74 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.28 kB	3.28 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.26 kB	8.26 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_error.js	851 kB	851 kB	⚠️ +269 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	851 kB	851 kB	⚠️ +269 B
link.js	888 kB	888 kB	⚠️ +269 B
routerDirect.js	880 kB	881 kB	⚠️ +269 B
withRouter.js	881 kB	881 kB	⚠️ +269 B
Overall change	4.36 MB	4.36 MB	⚠️ +1.34 kB

…back

ijjk · 2020-05-18T22:42:08Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
buildDuration	12.3s	12.4s	⚠️ +71ms
nodeModulesSize	60.4 MB	60.4 MB	⚠️ +1.05 kB

Page Load Tests Overall increase ✓

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.088	2.082	-0.01
/ avg req/sec	1197.48	1200.78	⚠️ +3.3
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.387	1.362	-0.02
/error-in-render avg req/sec	1802.22	1836.17	⚠️ +33.95

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.js gzip	6.71 kB	6.71 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..fc14.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.module.js gzip	5.74 kB	5.74 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.28 kB	3.28 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.26 kB	8.26 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
buildDuration	13.2s	13.2s	⚠️ +25ms
nodeModulesSize	60.4 MB	60.4 MB	⚠️ +1.05 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.js gzip	6.71 kB	6.71 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..fc14.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
main-HASH.module.js gzip	5.74 kB	5.74 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.28 kB	3.28 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.26 kB	8.26 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js error/export-fallback	Change
_error.js	851 kB	851 kB	⚠️ +269 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	851 kB	851 kB	⚠️ +269 B
link.js	888 kB	888 kB	⚠️ +269 B
routerDirect.js	880 kB	881 kB	⚠️ +269 B
withRouter.js	881 kB	881 kB	⚠️ +269 B
Overall change	4.36 MB	4.36 MB	⚠️ +1.34 kB

ijjk added 2 commits May 18, 2020 14:13

Add error when exporting pages with fallback: true

90b68b1

Account for exportPathMap

695b0db

ijjk added this to the 9.4.2 milestone May 18, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners May 18, 2020 19:25

Timer reviewed May 18, 2020

View reviewed changes

errors/ssg-fallback-true-export.md Outdated Show resolved Hide resolved

ijjk added 2 commits May 18, 2020 14:28

Merge remote-tracking branch 'upstream/canary' into error/export-fall…

9b69de7

…back

update errsh wording

58790bf

This comment has been minimized.

Sign in to view

ijjk added 2 commits May 18, 2020 17:24

Merge remote-tracking branch 'upstream/canary' into error/export-fall…

19a5960

…back

ignore check for build export

c7f4303

Merge branch 'canary' into error/export-fallback

9fb2304

Timer approved these changes May 19, 2020

View reviewed changes

Timer added the Type: Enhancement label May 19, 2020

Timer merged commit ef42246 into vercel:canary May 19, 2020

Timer deleted the error/export-fallback branch May 19, 2020 13:29

chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020

Add error when exporting pages with fallback: true (vercel#13063)

6e2f4bf

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

Add error when exporting pages with fallback: true (vercel#13063)

8d4c942

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add error when exporting pages with fallback: true #13063

Add error when exporting pages with fallback: true #13063

ijjk commented May 18, 2020

ijjk commented May 18, 2020

This comment has been minimized.

ijjk commented May 18, 2020

Add error when exporting pages with fallback: true #13063

Add error when exporting pages with fallback: true #13063

Conversation

ijjk commented May 18, 2020

ijjk commented May 18, 2020

Stats from current PR

This comment has been minimized.

ijjk commented May 18, 2020

Stats from current PR