Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove taskr typescript plugin as it's no longer used #13081

Merged

Conversation

timneutkens
Copy link
Member

Follow up to #13049

@timneutkens timneutkens requested review from ijjk, lfades and Timer as code owners May 19, 2020 07:21
@ijjk
Copy link
Member

ijjk commented May 19, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
buildDuration 11.1s 10.8s -353ms
nodeModulesSize 61.8 MB 61.8 MB
Page Load Tests Overall increase ✓
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
/ failed reqs 0 0
/ total time (seconds) 1.994 1.86 -0.13
/ avg req/sec 1253.74 1343.96 ⚠️ +90.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.254 1.238 -0.02
/error-in-render avg req/sec 1992.99 2018.72 ⚠️ +25.73
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b058.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
main-HASH.module.js gzip 5.69 kB 5.69 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.22 kB 8.22 kB
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
index.html gzip 928 B 928 B
link.html gzip 938 B 938 B
withRouter.html gzip 925 B 925 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
buildDuration 11.3s 11.4s ⚠️ +133ms
nodeModulesSize 61.8 MB 61.8 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..b058.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
main-HASH.module.js gzip 5.69 kB 5.69 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.22 kB 8.22 kB
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary timneutkens/next.js add/remove-unused-taskr-plugin Change
_error.js 843 kB 843 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 843 kB 843 kB
link.js 881 kB 881 kB
routerDirect.js 873 kB 873 kB
withRouter.js 873 kB 873 kB
Overall change 4.32 MB 4.32 MB

@timneutkens timneutkens merged commit 155c815 into vercel:canary May 19, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens timneutkens deleted the add/remove-unused-taskr-plugin branch February 12, 2021 13:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants