Add some good defaults to code-splitting #1644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the pages count increases, it's hard to use a module on all the pages. So, now we'll pick a module which is used at-least in half of the pages. This gives us dramatic space save in individual pages.
|
I'm 100% ok with this, but I think we should have an example in the |
|
How about if we expose a function to do it in next.config.js? |
|
Yeah, my point was, before we make that decision (which is not an easy one), I'd like to have a escape hatch for people to revert back or change to whatever constant they want. |
|
@rauchg Okay sure. I'll play with it and make it configurable. |
|
@rauchg check now. |
|
We took #1659 (comment) which is pretty similar but without the public API. |
gcpantazis
pushed a commit
to gcpantazis/next.js
that referenced
this pull request
Jan 22, 2018
A while ago (in vercel#1644) @arunoda updated the default for minimum refs to chunk a file into commons from the previous (which I believe was a static integer, or at least was at some point), and made it so that the file had to be used in > 50% of the pages. The problem is that people may use pages in different ways, particularly if they're using a custom server instead of the default page routing. For example, I use Styled Components, and put a `styles.js` file alongside my various page JSX files. Others may colocate JSX components inside pages, which could be very reasonable depending on the project. The point is, it's very possible to load up your /pages directory with JS files that add into the default logic's perception of "page count", since there's no singular way to determine what is and is not a page without analyzing the code within. I'd propose that leave this as the default behavior, since that makes sense if you're using Next in the OOTB manner, but allow for configuration if needed. @rauchg suggested as much in vercel#1644 but it seems like that fell out in the final version (vercel#1659)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move any module in 0.5 of total pages into the commons bundle.
As the pages count increases, it's hard to use a module on all the
pages.
So, now we'll pick a module which is used at-least in half of the pages.
This gives us dramatic space save in individual pages.
Here's the Zeit.co's page sizes without this fix:
Here's with this fix:
