Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .next also in subfolders #16962

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Ignore .next also in subfolders #16962

merged 2 commits into from
Sep 9, 2020

Conversation

borekb
Copy link
Contributor

@borekb borekb commented Sep 9, 2020

As the example is about Yarn workspaces, it should gitignore .next recursively.

Unverified

This user has not yet uploaded their public signing key.
@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 9, 2020
@ijjk
Copy link
Member

ijjk commented Sep 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary borekb/next.js codespace-1 Change
buildDuration 13.3s 13.1s -228ms
nodeModulesSize 56.7 MB 56.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary borekb/next.js codespace-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.334 2.281 -0.05
/ avg req/sec 1071.13 1096.08 +24.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.344 1.284 -0.06
/error-in-render avg req/sec 1859.92 1947.22 +87.3
Client Bundles (main, webpack, commons)
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-6743a22..e6ce.js gzip 7 kB 7 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.5 kB 57.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-3b374ae..dule.js gzip 6.07 kB 6.07 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary borekb/next.js codespace-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary borekb/next.js codespace-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary borekb/next.js codespace-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary borekb/next.js codespace-1 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary borekb/next.js codespace-1 Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 994 B 994 B
Overall change 3 kB 3 kB

Serverless Mode
General
vercel/next.js canary borekb/next.js codespace-1 Change
buildDuration 14.3s 14.8s ⚠️ +504ms
nodeModulesSize 56.7 MB 56.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-6743a22..e6ce.js gzip 7 kB 7 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.5 kB 57.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-3b374ae..dule.js gzip 6.07 kB 6.07 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary borekb/next.js codespace-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary borekb/next.js codespace-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary borekb/next.js codespace-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary borekb/next.js codespace-1 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary borekb/next.js codespace-1 Change
_error.js 1.03 MB 1.03 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.03 MB 1.03 MB
link.js 1.08 MB 1.08 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.31 MB 5.31 MB
Commit: 42705b9

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member

ijjk commented Sep 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary borekb/next.js codespace-1 Change
buildDuration 12.4s 12.3s -90ms
nodeModulesSize 56.7 MB 56.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary borekb/next.js codespace-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.176 2.173 0
/ avg req/sec 1148.88 1150.5 +1.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.189 1.153 -0.04
/error-in-render avg req/sec 2102.99 2168.27 +65.28
Client Bundles (main, webpack, commons)
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-6743a22..e6ce.js gzip 7 kB 7 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.5 kB 57.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-3b374ae..dule.js gzip 6.07 kB 6.07 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary borekb/next.js codespace-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary borekb/next.js codespace-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary borekb/next.js codespace-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary borekb/next.js codespace-1 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary borekb/next.js codespace-1 Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 994 B 994 B
Overall change 3 kB 3 kB

Serverless Mode
General
vercel/next.js canary borekb/next.js codespace-1 Change
buildDuration 13.7s 13.5s -201ms
nodeModulesSize 56.7 MB 56.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-6743a22..e6ce.js gzip 7 kB 7 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.5 kB 57.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary borekb/next.js codespace-1 Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-3b374ae..dule.js gzip 6.07 kB 6.07 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary borekb/next.js codespace-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary borekb/next.js codespace-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary borekb/next.js codespace-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary borekb/next.js codespace-1 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary borekb/next.js codespace-1 Change
_error.js 1.03 MB 1.03 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.03 MB 1.03 MB
link.js 1.08 MB 1.08 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.31 MB 5.31 MB
Commit: 84b4ad3

@kodiakhq kodiakhq bot merged commit 99998f0 into vercel:canary Sep 9, 2020
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
As the example is about Yarn workspaces, it should gitignore `.next` recursively.
@borekb borekb deleted the codespace-1 branch July 9, 2021 07:10
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants