Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom document error message #17048

Merged
merged 3 commits into from
Sep 12, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Sep 12, 2020

No description provided.

Unverified

This user has not yet uploaded their public signing key.
ijjk
ijjk previously approved these changes Sep 12, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
buildDuration 14.1s 13.8s -343ms
nodeModulesSize 60 MB 60 MB ⚠️ +309 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
/ failed reqs 0 0
/ total time (seconds) 2.543 2.535 -0.01
/ avg req/sec 982.99 986.2 +3.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.539 1.6 ⚠️ +0.06
/error-in-render avg req/sec 1624.55 1562.12 ⚠️ -62.43
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-3d83558..e210.js gzip 7.02 kB 7.02 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js better-custom-document-error Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary Timer/next.js better-custom-document-error Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js better-custom-document-error Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
buildDuration 15.4s 15.5s ⚠️ +107ms
nodeModulesSize 60 MB 60 MB ⚠️ +309 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-3d83558..e210.js gzip 7.02 kB 7.02 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js better-custom-document-error Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary Timer/next.js better-custom-document-error Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
_error.js 1.03 MB 1.03 MB ⚠️ +37 B
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.04 MB 1.04 MB ⚠️ +37 B
link.js 1.08 MB 1.08 MB ⚠️ +37 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +37 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +37 B
Overall change 5.31 MB 5.31 MB ⚠️ +185 B
Commit: be86172

@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
buildDuration 13.6s 13.2s -418ms
nodeModulesSize 60 MB 60 MB ⚠️ +309 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
/ failed reqs 0 0
/ total time (seconds) 2.395 2.419 ⚠️ +0.02
/ avg req/sec 1043.85 1033.59 ⚠️ -10.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.447 1.471 ⚠️ +0.02
/error-in-render avg req/sec 1727.65 1699.73 ⚠️ -27.92
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-3d83558..e210.js gzip 7.02 kB 7.02 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js better-custom-document-error Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary Timer/next.js better-custom-document-error Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js better-custom-document-error Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
buildDuration 14.7s 14.9s ⚠️ +180ms
nodeModulesSize 60 MB 60 MB ⚠️ +309 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-3d83558..e210.js gzip 7.02 kB 7.02 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js better-custom-document-error Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary Timer/next.js better-custom-document-error Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
_error.js 1.03 MB 1.03 MB ⚠️ +37 B
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.04 MB 1.04 MB ⚠️ +37 B
link.js 1.08 MB 1.08 MB ⚠️ +37 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +37 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +37 B
Overall change 5.31 MB 5.31 MB ⚠️ +185 B
Commit: f40f1cc

@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Failing test suites

Commit: be86172

test/integration/missing-document-component-error/test/index.test.js

  • Missing _document components error > should detect multiple missing document components
Expand output

● Missing _document components error › should detect multiple missing document components

TIMED OUT: /Head, NextScript/

warn  - Your custom Document (pages/_document) did not render all the required subcomponents.
Missing components: <Head />, <NextScript />
Read how to fix here: https://err.sh/next.js/missing-document-component

  377 | 
  378 |   if (hardError) {
> 379 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  380 |   }
  381 |   return false
  382 | }

  at check (lib/next-test-utils.js:379:11)
  at checkMissing (integration/missing-document-component-error/test/index.test.js:34:3)
  at Object.<anonymous> (integration/missing-document-component-error/test/index.test.js:138:5)

@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
buildDuration 12.1s 12.2s ⚠️ +149ms
nodeModulesSize 60 MB 60 MB ⚠️ +309 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
/ failed reqs 0 0
/ total time (seconds) 2.129 2.164 ⚠️ +0.04
/ avg req/sec 1174.5 1155.52 ⚠️ -18.98
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.163 1.168 0
/error-in-render avg req/sec 2150.24 2140.56 ⚠️ -9.68
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-3d83558..e210.js gzip 7.02 kB 7.02 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js better-custom-document-error Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary Timer/next.js better-custom-document-error Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js better-custom-document-error Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
buildDuration 13.9s 13.8s -158ms
nodeModulesSize 60 MB 60 MB ⚠️ +309 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-3d83558..e210.js gzip 7.02 kB 7.02 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js better-custom-document-error Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary Timer/next.js better-custom-document-error Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary Timer/next.js better-custom-document-error Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js better-custom-document-error Change
_error.js 1.03 MB 1.03 MB ⚠️ +37 B
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.04 MB 1.04 MB ⚠️ +37 B
link.js 1.08 MB 1.08 MB ⚠️ +37 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +37 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +37 B
Overall change 5.31 MB 5.31 MB ⚠️ +185 B
Commit: acd51b2

@kodiakhq kodiakhq bot merged commit 9b22dc4 into vercel:canary Sep 12, 2020
@Timer Timer deleted the better-custom-document-error branch September 14, 2020 02:36
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants